[master] deb: add "Pre-Depends: ${misc:Pre-Depends}" for compat with debhelper > 13 by thaJeztah · Pull Request #696 · docker/docker-ce-packaging

thaJeztah · 2022-05-19T13:58:38Z

Commit f9ac2f6 (#686) updated the "debhelper compat
level" to 13, which seems to have introduced a regression when executing the
preRM and postInst scripts;

invoke-rc.d: syntax error: unknown option "--skip-systemd-native"
   dpkg: error processing package docker-ce (--install):
   installed docker-ce package post-installation script subprocess returned error exit status 1

Searching for the cause of this regression, I found this mention in the debhelper(7)
man-page: https://man7.org/linux/man-pages/man7/debhelper.7.html

**Retroactively removed in debhelper/13.5:**
(...)
This change makes dh_installinit inject a
misc:Pre-Depends for init-system-helpers (>= 1.54~).
Please ensure that the package lists
${misc:Pre-Depends} in its Pre-Depends field before
upgrading to compat 12.

This patch adds the recommended Pre-depends

thaJeztah · 2022-05-19T13:59:57Z

Unfortunately, it looks like this doesn't solve the issue;

dpkg: warning: ignoring pre-dependency problem!

Setting up docker-ce (5:0.0.0-20220519102430-0e4dde2-0~ubuntu-bionic) ...
invoke-rc.d: syntax error: unknown option "--skip-systemd-native"
dpkg: error processing package docker-ce (--install):
installed docker-ce package post-installation script subprocess returned error exit status 1
Errors were encountered while processing:
docker-ce

+ REPO_URL=https://download.docker.com/linux/ubuntu
+ echo '[DEBUG] Installing engine dependencies from https://download.docker.com/linux/ubuntu'
  [DEBUG] Installing engine dependencies from https://download.docker.com/linux/ubuntu
+ update-ca-certificates -f
  Clearing symlinks in /etc/ssl/certs...
  done.
  Updating certificates in /etc/ssl/certs...
  128 added, 0 removed; done.
  Running hooks in /etc/ca-certificates/update.d...
  done.
+ curl -fsSL https://download.docker.com/linux/ubuntu/gpg
+ apt-key add -
  OK
+ [[ bionic == \s\i\d ]]
  ++ dpkg --print-architecture
+ ARCH=amd64
+ echo 'deb [arch=amd64] https://download.docker.com/linux/ubuntu bionic test'
+ apt-get update
  Hit:1 http://archive.ubuntu.com/ubuntu bionic InRelease
  Hit:2 http://security.ubuntu.com/ubuntu bionic-security InRelease
  Hit:3 http://archive.ubuntu.com/ubuntu bionic-updates InRelease
  Hit:4 http://archive.ubuntu.com/ubuntu bionic-backports InRelease
  Get:5 https://download.docker.com/linux/ubuntu bionic InRelease [64.4 kB]
  Get:6 https://download.docker.com/linux/ubuntu bionic/test amd64 Packages [48.9 kB]
  Fetched 113 kB in 1s (168 kB/s)
  Reading package lists... Done
  ++ find packaging/deb/debbuild/ubuntu-bionic/ -type f -name '*.deb'
+ packages='packaging/deb/debbuild/ubuntu-bionic/docker-buildx-plugin_0.8.2~ubuntu-bionic_amd64.deb
  packaging/deb/debbuild/ubuntu-bionic/docker-ce-cli_0.0.0-20220519102430-0e4dde2-0~ubuntu-bionic_amd64.deb
  packaging/deb/debbuild/ubuntu-bionic/docker-ce-rootless-extras_0.0.0-20220519102430-0e4dde2-0~ubuntu-bionic_amd64.deb
  packaging/deb/debbuild/ubuntu-bionic/docker-ce_0.0.0-20220519102430-0e4dde2-0~ubuntu-bionic_amd64.deb
  packaging/deb/debbuild/ubuntu-bionic/docker-compose-plugin_2.5.1~ubuntu-bionic_amd64.deb
  packaging/deb/debbuild/ubuntu-bionic/docker-scan-plugin_0.17.0~ubuntu-bionic_amd64.deb'
  ++ echo 'packaging/deb/debbuild/ubuntu-bionic/docker-buildx-plugin_0.8.2~ubuntu-bionic_amd64.deb
  packaging/deb/debbuild/ubuntu-bionic/docker-ce-cli_0.0.0-20220519102430-0e4dde2-0~ubuntu-bionic_amd64.deb
  packaging/deb/debbuild/ubuntu-bionic/docker-ce-rootless-extras_0.0.0-20220519102430-0e4dde2-0~ubuntu-bionic_amd64.deb
  packaging/deb/debbuild/ubuntu-bionic/docker-ce_0.0.0-20220519102430-0e4dde2-0~ubuntu-bionic_amd64.deb
  packaging/deb/debbuild/ubuntu-bionic/docker-compose-plugin_2.5.1~ubuntu-bionic_amd64.deb
  packaging/deb/debbuild/ubuntu-bionic/docker-scan-plugin_0.17.0~ubuntu-bionic_amd64.deb'
  ++ awk '$0="./"$0'
  ++ xargs
+ packages='./packaging/deb/debbuild/ubuntu-bionic/docker-buildx-plugin_0.8.2~ubuntu-bionic_amd64.deb ./packaging/deb/debbuild/ubuntu-bionic/docker-ce-cli_0.0.0-20220519102430-0e4dde2-0~ubuntu-bionic_amd64.deb ./packaging/deb/debbuild/ubuntu-bionic/docker-ce-rootless-extras_0.0.0-20220519102430-0e4dde2-0~ubuntu-bionic_amd64.deb ./packaging/deb/debbuild/ubuntu-bionic/docker-ce_0.0.0-20220519102430-0e4dde2-0~ubuntu-bionic_amd64.deb ./packaging/deb/debbuild/ubuntu-bionic/docker-compose-plugin_2.5.1~ubuntu-bionic_amd64.deb ./packaging/deb/debbuild/ubuntu-bionic/docker-scan-plugin_0.17.0~ubuntu-bionic_amd64.deb'
+ set -x
+ dpkg --ignore-depends=containerd.io,iptables,libdevmapper,libdevmapper1.02.1 --force-depends -i ./packaging/deb/debbuild/ubuntu-bionic/docker-buildx-plugin_0.8.2~ubuntu-bionic_amd64.deb ./packaging/deb/debbuild/ubuntu-bionic/docker-ce-cli_0.0.0-20220519102430-0e4dde2-0~ubuntu-bionic_amd64.deb ./packaging/deb/debbuild/ubuntu-bionic/docker-ce-rootless-extras_0.0.0-20220519102430-0e4dde2-0~ubuntu-bionic_amd64.deb ./packaging/deb/debbuild/ubuntu-bionic/docker-ce_0.0.0-20220519102430-0e4dde2-0~ubuntu-bionic_amd64.deb ./packaging/deb/debbuild/ubuntu-bionic/docker-compose-plugin_2.5.1~ubuntu-bionic_amd64.deb ./packaging/deb/debbuild/ubuntu-bionic/docker-scan-plugin_0.17.0~ubuntu-bionic_amd64.deb
  Selecting previously unselected package docker-buildx-plugin.
  (Reading database ... 6945 files and directories currently installed.)
  Preparing to unpack .../docker-buildx-plugin_0.8.2~ubuntu-bionic_amd64.deb ...
  Unpacking docker-buildx-plugin (0.8.2~ubuntu-bionic) ...
  Selecting previously unselected package docker-ce-cli.
  Preparing to unpack .../docker-ce-cli_0.0.0-20220519102430-0e4dde2-0~ubuntu-bionic_amd64.deb ...
  Unpacking docker-ce-cli (5:0.0.0-20220519102430-0e4dde2-0~ubuntu-bionic) ...
  Selecting previously unselected package docker-ce-rootless-extras.
  Preparing to unpack .../docker-ce-rootless-extras_0.0.0-20220519102430-0e4dde2-0~ubuntu-bionic_amd64.deb ...
  Unpacking docker-ce-rootless-extras (5:0.0.0-20220519102430-0e4dde2-0~ubuntu-bionic) ...
  Selecting previously unselected package docker-ce.
  dpkg: regarding .../docker-ce_0.0.0-20220519102430-0e4dde2-0~ubuntu-bionic_amd64.deb containing docker-ce, pre-dependency problem:
  docker-ce pre-depends on init-system-helpers (>= 1.54~)
  init-system-helpers is installed, but is version 1.51.

dpkg: warning: ignoring pre-dependency problem!
Preparing to unpack .../docker-ce_0.0.0-20220519102430-0e4dde2-0~ubuntu-bionic_amd64.deb ...
Unpacking docker-ce (5:0.0.0-20220519102430-0e4dde2-0~ubuntu-bionic) ...
Selecting previously unselected package docker-compose-plugin.
Preparing to unpack .../docker-compose-plugin_2.5.1~ubuntu-bionic_amd64.deb ...
Unpacking docker-compose-plugin (2.5.1~ubuntu-bionic) ...
Selecting previously unselected package docker-scan-plugin.
Preparing to unpack .../docker-scan-plugin_0.17.0~ubuntu-bionic_amd64.deb ...
Unpacking docker-scan-plugin (0.17.0~ubuntu-bionic) ...
Setting up docker-buildx-plugin (0.8.2~ubuntu-bionic) ...
Setting up docker-ce-cli (5:0.0.0-20220519102430-0e4dde2-0~ubuntu-bionic) ...
Setting up docker-compose-plugin (2.5.1~ubuntu-bionic) ...
Setting up docker-scan-plugin (0.17.0~ubuntu-bionic) ...
dpkg: docker-ce-rootless-extras: dependency problems, but configuring anyway as you requested:
docker-ce-rootless-extras depends on dbus-user-session; however:
Package dbus-user-session is not installed.

Setting up docker-ce-rootless-extras (5:0.0.0-20220519102430-0e4dde2-0~ubuntu-bionic) ...
dpkg: docker-ce: dependency problems, but configuring anyway as you requested:
docker-ce depends on init-system-helpers (>= 1.54~); however:
Version of init-system-helpers on system is 1.51.

Setting up docker-ce (5:0.0.0-20220519102430-0e4dde2-0~ubuntu-bionic) ...
invoke-rc.d: syntax error: unknown option "--skip-systemd-native"
dpkg: error processing package docker-ce (--install):
installed docker-ce package post-installation script subprocess returned error exit status 1
Errors were encountered while processing:
docker-ce

thaJeztah · 2022-05-19T14:58:59Z

I'll rebase this one, now that #697 is merged, CI should go "red" ❌ and show the problem

thaJeztah · 2022-05-19T15:39:34Z

So with this change, the package has indeed a new Pre-Dependency included;

dpkg-deb -I ./docker-ce_0.0.0-20220519102430-0e4dde2-0~ubuntu-bionic_amd64.deb
 new Debian package, version 2.0.
 size 21108028 bytes: control archive=2164 bytes.
      39 bytes,     2 lines      conffiles
    1309 bytes,    24 lines      control
     305 bytes,     5 lines      md5sums
    1779 bytes,    63 lines   *  postinst             #!/bin/sh
     872 bytes,    20 lines   *  postrm               #!/bin/sh
     188 bytes,     5 lines   *  preinst              #!/bin/sh
     433 bytes,    10 lines   *  prerm                #!/bin/sh
 Package: docker-ce
 Version: 5:0.0.0-20220519102430-0e4dde2-0~ubuntu-bionic
 Architecture: amd64
 Maintainer: Docker <support@docker.com>
 Installed-Size: 92444
 Pre-Depends: init-system-helpers (>= 1.54~)
 Depends: containerd.io (>= 1.6.4), docker-ce-cli, iptables, libseccomp2 (>= 2.3.0), libc6 (>= 2.8), libdevmapper1.02.1 (>= 2:1.02.97), libsystemd0
 Recommends: apparmor, ca-certificates, docker-ce-rootless-extras, git, libltdl7, pigz, procps, xz-utils
 Suggests: aufs-tools, cgroupfs-mount | cgroup-lite
 Conflicts: docker (<< 1.5~), docker-engine, docker-engine-cs, docker.io, lxc-docker, lxc-docker-virtual-package
 Replaces: docker-engine
 Section: admin
 Priority: optional
 Homepage: https://www.docker.com
 Description: Docker: the open-source application container engine
  Docker is a product for you to build, ship and run any application as a
  lightweight container
  .
  Docker containers are both hardware-agnostic and platform-agnostic. This means
  they can run anywhere, from your laptop to the largest cloud compute instance and
  everything in between - and they don't require you to use a particular
  language, framework or packaging system. That makes them great building blocks
  for deploying and scaling web apps, databases, and backend services without
  depending on a particular stack or provider.

I'm still curious how it worked before, or is this just that it requires the new version, so we must manually upgrade the version for it to work? (Or enable the "backports" repository) 🤔

thaJeztah · 2022-05-19T15:41:53Z

I guess it's also a combination of how the verify script explicitly disables some dependency resolution (to prevent it satisfying the newly built packages with older versions of the packages).

thaJeztah · 2022-05-19T16:07:44Z

So default version on bionic is 1.51;
https://packages.ubuntu.com/bionic/init-system-helpers

bionic-backports version is 1.56;
https://packages.ubuntu.com/bionic-backports/init-system-helpers

So we need to have it installed from backports indeed.

At a glance, it looks like bionic-backports is enabled and configured by default;

cat /etc/apt/sources.list | grep backports
## Also, please note that software in backports WILL NOT receive any review
deb http://archive.ubuntu.com/ubuntu/ bionic-backports main restricted universe multiverse
# deb-src http://archive.ubuntu.com/ubuntu/ bionic-backports main restricted universe multiverse

But backports are not considered by default, so we need some way to define that it should use them; https://help.ubuntu.com/community/UbuntuBackports

Perhaps some conditional dependency for 18.04 🤔

thaJeztah · 2022-05-19T16:09:08Z

Looks like it can't be defined in the dependencies (to force install from backports); https://unix.stackexchange.com/a/526621/78656

tianon · 2022-05-19T17:48:35Z

Yeah sorry -- IMO our best short-term option is #699 (full revert of my PR).

thaJeztah · 2022-05-19T17:59:10Z

Would adding this be a "good thing to do" in either case? (curious)

… > 13 Commit f9ac2f6 updated the "debhelper compat level" to 13, which seems to have introduced a regression when executing the preRM and postInst scripts; invoke-rc.d: syntax error: unknown option "--skip-systemd-native" dpkg: error processing package docker-ce (--install): installed docker-ce package post-installation script subprocess returned error exit status 1 Searching for the cause of this regression, I found this mention in the debhelper(7) man-page: https://man7.org/linux/man-pages/man7/debhelper.7.html **Retroactively removed in debhelper/13.5:** (...) This change makes dh_installinit inject a misc:Pre-Depends for init-system-helpers (>= 1.54~). Please ensure that the package lists ${misc:Pre-Depends} in its Pre-Depends field before upgrading to compat 12. This patch adds the recommended Pre-depends Signed-off-by: Sebastiaan van Stijn <github@gone.nl>

thaJeztah · 2022-05-19T18:00:06Z

(rebased to see if it still works after we reverted the other one)

tianon · 2022-05-19T18:05:05Z

Ah, I guess from that perspective, yes? It doesn't hurt anything (it'll probably be empty and no-op in many cases).

thaJeztah marked this pull request as draft May 19, 2022 13:58

thaJeztah mentioned this pull request May 19, 2022

[master] Makefile: add "verify" target to test install of packages #697

Merged

thaJeztah force-pushed the fix_dh_installinit branch from 2d2bb98 to f10f479 Compare May 19, 2022 15:00

thaJeztah changed the title ~~deb: add "Pre-Depends: ${misc:Pre-Depends}" for compat with debhelper > 13~~ [master] deb: add "Pre-Depends: ${misc:Pre-Depends}" for compat with debhelper > 13 May 19, 2022

thaJeztah mentioned this pull request May 19, 2022

[master] deb: use debhelper-compat=11 for compatibility with ubuntu 18.04 #698

Closed

thaJeztah force-pushed the fix_dh_installinit branch from f10f479 to a10a6d5 Compare May 19, 2022 17:59

thaJeztah mentioned this pull request Jun 21, 2023

[master] Update "deb" packaging to use "dh_installsystemd", and remove upstart script #914

Merged

neersighted closed this in #914 Jul 21, 2023

thaJeztah deleted the fix_dh_installinit branch July 21, 2023 13:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[master] deb: add "Pre-Depends: ${misc:Pre-Depends}" for compat with debhelper > 13#696

[master] deb: add "Pre-Depends: ${misc:Pre-Depends}" for compat with debhelper > 13#696
thaJeztah wants to merge 1 commit intodocker:masterfrom
thaJeztah:fix_dh_installinit

thaJeztah commented May 19, 2022

Uh oh!

thaJeztah commented May 19, 2022

Uh oh!

thaJeztah commented May 19, 2022

Uh oh!

thaJeztah commented May 19, 2022

Uh oh!

thaJeztah commented May 19, 2022

Uh oh!

thaJeztah commented May 19, 2022

Uh oh!

thaJeztah commented May 19, 2022

Uh oh!

tianon commented May 19, 2022

Uh oh!

thaJeztah commented May 19, 2022

Uh oh!

thaJeztah commented May 19, 2022

Uh oh!

tianon commented May 19, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Conversation

thaJeztah commented May 19, 2022

Uh oh!

thaJeztah commented May 19, 2022

Uh oh!

thaJeztah commented May 19, 2022

Uh oh!

thaJeztah commented May 19, 2022

Uh oh!

thaJeztah commented May 19, 2022

Uh oh!

thaJeztah commented May 19, 2022

Uh oh!

thaJeztah commented May 19, 2022

Uh oh!

tianon commented May 19, 2022

Uh oh!

thaJeztah commented May 19, 2022

Uh oh!

thaJeztah commented May 19, 2022

Uh oh!

tianon commented May 19, 2022

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants