bake: allow variables across files#538
Merged
Merged
Conversation
tonistiigi
force-pushed
the
vars-multi-file
branch
2 times, most recently
from
February 10, 2021 22:15
12060e3 to
f696818
Compare
crazy-max
approved these changes
Feb 11, 2021
crazy-max
left a comment
Member
There was a problem hiding this comment.
LGTM! This is a nice enhancement that could be used on CI.
AkihiroSuda
approved these changes
Feb 25, 2021
Collaborator
|
Needs rebase |
Signed-off-by: Tonis Tiigi <tonistiigi@gmail.com>
tonistiigi
force-pushed
the
vars-multi-file
branch
from
February 26, 2021 00:30
f696818 to
0e9d646
Compare
Member
Author
|
Rebased |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
depends on #532
Updates HCL parsing so that when multiple files are specified, one file can use variables defined in another file.
@crazy-max @vanstee