Add bullseye & bullseye-slim versions#357
Merged
tianon merged 1 commit intodocker-library:masterfrom Aug 16, 2021
Merged
Conversation
Contributor
Author
in |
Closed
Member
|
As in docker-library/python#633, this should also drop all traces of |
Member
|
(You'll also need to update/run |
3adcfd4 to
5c29101
Compare
Contributor
Author
|
Done, CI is green except the same |
tianon
reviewed
Aug 16, 2021
Member
tianon
left a comment
There was a problem hiding this comment.
Very close, just a couple minor nits -- happy to take over from here if you'd prefer. 👍
versions.sh
Outdated
Comment on lines
71
to
72
| "buster", | ||
| if env.rcVersion == "2.6" then | ||
| "stretch" | ||
| else empty end | ||
| "bullseye" |
Member
There was a problem hiding this comment.
These should be in the opposite order, and ought to have matching whitespace 😅
Suggested change
| "buster", | |
| if env.rcVersion == "2.6" then | |
| "stretch" | |
| else empty end | |
| "bullseye" | |
| "bullseye", | |
| "buster" |
Contributor
Author
There was a problem hiding this comment.
oh, whitespaces 🤦
So AFAIU we want bullseye to be the default one?
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Aug 16, 2021
Changes: - docker-library/ruby@301b52c: Merge pull request docker-library/ruby#357 from ojab/add_bullseye - docker-library/ruby@4916859: Add `bullseye` & `bullseye-slim` versions, drop `stretch` & `stretch-slim` - docker-library/ruby@fc5c093: Merge pull request docker-library/ruby#358 from infosiftr/confused - docker-library/ruby@e439599: Update patch file shasum
p8
added a commit
to p8/buildkite-config
that referenced
this pull request
Aug 19, 2021
The latest Ruby Docker image upgraded from Debian to Bullseye: docker-library/ruby#357 Bullseye no longer supports Node v10.x, which cause NPM to not be installed, resulting in failing builds. As Node v10.x is no longer supported we should switch to a supported version. Active support for v14 ends in November 2021, so we might as well switch to v16. See: https://endoflife.date/nodejs Steps to reproduce: $ git clone https://github.com/rails/rails $ cd rails $ git clone https://github.com/rails/buildkite-config .buildkite/ $ RUBY_IMAGE=ruby:3.0.2 docker-compose -f .buildkite/docker-compose.yml build base && CI=1 docker-compose -f .buildkite/docker-compose.yml run actionview runner actionview 'rake test:ujs'
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bullseye is out, let's add it.
Closes #356