Merged
Conversation
Keep Alpine 3.16 to support PHP 8.0
tianon
reviewed
May 10, 2023
| if [ "$rcVersion" = '8.0' ] && [[ "$suite" = alpine* ]] && [ "$suite" != 'alpine3.16' ]; then | ||
| continue | ||
| fi | ||
| # https://github.com/docker-library/php/pull/1405 |
Member
There was a problem hiding this comment.
With no force pushes, this is impressive - you rolled the dice and won 😂 ❤️
Member
|
Thank you for doing this so thoroughly 😊 🙇 |
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
May 11, 2023
Changes: - docker-library/php@6985ff10: Merge pull request docker-library/php#1405 from jnoordsij/add-alpine-3.18 - docker-library/php@9a3c8d8a: Add Alpine 3.18 variant for PHP >= 8.1
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
May 11, 2023
Changes: - docker-library/php@2a4ded09: Update 8.2-rc - docker-library/php@21967e6c: Update 8.2 to 8.2.6 - docker-library/php@6985ff10: Merge pull request docker-library/php#1405 from jnoordsij/add-alpine-3.18 - docker-library/php@9a3c8d8a: Add Alpine 3.18 variant for PHP >= 8.1
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR provides the latest Alpine version (3.18, see https://alpinelinux.org/posts/Alpine-3.18.0-released.html)).
Alpine 3.18 variant is only added for PHP versions with OpenSSL support (i.e. PHP >= 8.1), see also #1348 (comment).
Alpine 3.16 is only kept around for PHP 8.0, as this is the latest compatible version; the Alpine 3.16 variant is removed for newer PHP versions (>= 8.1).
Based on #1348.