Conversation
tianon
approved these changes
Mar 18, 2022
Member
tianon
left a comment
There was a problem hiding this comment.
Nice, thank you!! I appreciate how thorough you were in fixing up/removing old code too. 😍
Just one minor comment, but this looks great to me!
Co-authored-by: Tianon Gravi <admwiggin@gmail.com>
Member
|
Verify Templating is finished, which is the only one we actually need here given it's all removals 😄 Thanks again! |
docker-library-bot
added a commit
to docker-library-bot/official-images
that referenced
this pull request
Mar 18, 2022
Changes: - docker-library/php@f275451: Remove 7.3 (docker-library/php#1270)
mvorisek
pushed a commit
to mvorisek/docker-library-php-lts
that referenced
this pull request
Mar 26, 2022
This reverts commit f275451.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHP 7.3 is no longer supported (see https://www.php.net/supported-versions.php).