Skip to content

fix: make getStorageClass() method public and fix IDE warnings #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dmitry-fa wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix: make getStorageClass() method public and fix IDE warnings #1

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions ...cloud-clients/google-cloud-storage/src/main/java/com/google/cloud/storage/BucketInfo.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -663,7 +663,7 @@ public String toString() {
.toString();
}

StorageClass getStorageClass() {
public StorageClass getStorageClass() {
return storageClass;
}
}
Expand Down Expand Up @@ -1249,7 +1249,7 @@ public Builder setLabels(Map<String, String> labels) {
@Override
public String apply(String input) {
// replace null values with empty strings
return input == null ? Data.<String>nullOf(String.class) : input;
return input == null ? Data.nullOf(String.class) : input;
Copy link

@pmakani pmakani Dec 23, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here.

}
});
}
Expand All @@ -1259,7 +1259,7 @@ public String apply(String input) {
@Override
public Builder setDefaultKmsKeyName(String defaultKmsKeyName) {
this.defaultKmsKeyName =
defaultKmsKeyName != null ? defaultKmsKeyName : Data.<String>nullOf(String.class);
defaultKmsKeyName != null ? defaultKmsKeyName : Data.nullOf(String.class);
return this;
}

Expand Down Expand Up @@ -1727,8 +1727,7 @@ public Rule apply(LifecycleRule lifecycleRule) {
}
if (retentionPeriod != null) {
if (Data.isNull(retentionPeriod)) {
bucketPb.setRetentionPolicy(
Data.<Bucket.RetentionPolicy>nullOf(Bucket.RetentionPolicy.class));
bucketPb.setRetentionPolicy(Data.nullOf(Bucket.RetentionPolicy.class));
} else {
Bucket.RetentionPolicy retentionPolicy = new Bucket.RetentionPolicy();
retentionPolicy.setRetentionPeriod(retentionPeriod);
Expand Down