This repository was archived by the owner on Dec 24, 2022. It is now read-only.
fixed a bug I reported in issue #4 also upgraded to PureScript 0.12#5
Open
dwhitney wants to merge 4 commits into
Open
fixed a bug I reported in issue #4 also upgraded to PureScript 0.12#5dwhitney wants to merge 4 commits into
dwhitney wants to merge 4 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey, I really enjoy using this library, and I found a bug, needed it fixed, and thought I could add a couple of functions that others might want too:
The bug was where
findFromRootwould not find some nodes becausefindDownwas not exhaustively searching siblings. To fix this I created a couple of new functions calledfindDownWhereandfindUpWherethat will exhaustively search in their respective ways and they differ fromfindDownandfindUpby taking a predicate (something I needed and thought would be helpful for others). This fixed the original issuefindFromRoothad. I also rewrotefindUpandfindDownin terms of their predicate-taking counterparts. I also added several tests to check my work.