Skip to content

Parse: minor optimizations #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
milosgajdos merged 1 commit into from
Apr 18, 2026
Merged

Parse: minor optimizations #26

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions reference.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,12 +228,14 @@ func splitDomain(name string) (string, string) {
// _ "crypto/sha256"
// )
func Parse(s string) (Reference, error) {
if s == "" {
return nil, ErrNameEmpty
}

matches := ReferenceRegexp.FindStringSubmatch(s)
if matches == nil {
if s == "" {
return nil, ErrNameEmpty
}
if ReferenceRegexp.FindStringSubmatch(strings.ToLower(s)) != nil {
if sl := strings.ToLower(s); sl != s && ReferenceRegexp.FindStringSubmatch(sl) != nil {
// Succeeds when lower-casing, so input contains an invalid repository name.
return nil, ErrNameContainsUppercase
}
return nil, ErrReferenceInvalidFormat
Expand Down
Loading