REF-5: Create GitHub based pipeline and fix the build toolchain#84
Merged
Merged
Conversation
Add a GitHub Actions workflow (Temurin 11 + Maven cache) running
mvn clean install on push and PRs to master.
Make the build reproducible on JDK 11 (required by the hsqldb 2.7.1 test
dependency) while keeping the published artifact Java 8 compatible:
- maven-compiler-plugin 3.3 -> 3.8.1, source/target 1.8 -> release 8
- demo: pin oiosaml3.java to ${project.version} instead of a stale version
- ignore HSQLDB mem.* scratch files left by DatabaseSessionHandlerTest
Restore certificate revocation tests: the previous test PKI was taken
down, so replace REVOKED_CERTIFICATE with a new revoked cert from the
live cti-gov.dk PKI and re-enable CRLCheckerTest.
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a GitHub Actions CI pipeline and fixes the build toolchain so
mvn clean installis reproducible and green..github/workflows/build.yml): runsmvn -B clean installon Temurin 11 with Maven dependency caching, triggered on push (master / feature / hotfix branches) and PRs tomaster.hsqldb 2.7.1test dependency, which is Java 11 bytecode) while keeping the published artifact Java 8 compatible:maven-compiler-plugin3.3→3.8.1,source/target 1.8→<release>8</release>(compiles against the Java 8 API so no newer API can leak into the bytecode).demo: pinoiosaml3.javato${project.version}instead of a stale hardcoded version.mem.*scratch files left byDatabaseSessionHandlerTest.REVOKED_CERTIFICATEis replaced with a new revoked cert from the livecti-gov.dkPKI andCRLCheckerTestis re-enabled.Verification
mvn clean installon Temurin 11: BUILD SUCCESS,Tests run: 107, Failures: 0, Errors: 0, Skipped: 0. The four revocation tests pass in sub-second time (vs. 75s timeouts against the dead PKI), confirming they genuinely exercise live OCSP/CRL.Notes / follow-ups
CRLCheckerTestcases make real outbound calls toca1.cti-gov.dkduring the build, including in CI — if GitHub runners cannot reach that host they will regress to slow timeouts/failures. Consider gating them behind a profile/tag if that becomes a problem.🤖 Generated with Claude Code