Always try to add a default @type and @language - #60
Closed
rknLA wants to merge 1 commit into
Closed
Conversation
| entry['@language'].setdefault('@none', term) | ||
| # add entries for no type and no language | ||
| entry['@type'].setdefault('@none', term) | ||
| entry['@language'].setdefault('@none', term) |
Collaborator
There was a problem hiding this comment.
I don't know but I am concerned about verbosity of the resulting document. What do you think about this?
12 tasks
Collaborator
|
Closing this as it introduces makes spec tests fail |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #59
In cases where @type was set, but not @language, one or the other would end up being an empty dictionary.
I have not run any tests on this, or added test cases, so that might need to be addressed before merging.