Update aiohttp support for Python 3.14. - #208
Merged
Merged
Conversation
- Only test with supported Python versions. - Drop testing of 3.8 - 3.9. - Require >= 3.10. - Add testing of 3.13 - 3.14. - Lint with 3.14.
- Update aiohttp document loader to work with Python 3.14. - Minimize async related changes to library code in this release. - In sync environment use `asyncio.run`. - In async environment use background thread. - AI pair programming used for this patch. This seemed to be the best of a few alternatives to fix Python 3.14 support while minimizing other changes. Future work could enable better concurrency.
davidlehn
force-pushed
the
update-aiohttp-support
branch
from
November 7, 2025 15:13
5589334 to
f7876f3
Compare
davidlehn
force-pushed
the
add-github-workflow
branch
from
November 7, 2025 15:14
01fe0f8 to
f9772ea
Compare
dlongley
approved these changes
Nov 7, 2025
Collaborator
|
Looks good! I got a bit mixed up with the versioning, but I'll take that up in de parent PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
asyncio.run.This change could use review from someone more familiar with asyncio/aiohttp. It might be good enough for now.