Ready for 3.4.3 PyPI/GitHub release

[alisnwu]

Release checklist for GitHub contributors

• All PRs/issues attached to the release are merged.
• All the badges on the README are passing.
• License information is verified as correct. If you are unsure, please comment below.
• Locally rendered documentation contains all appropriate pages, including API references (check no modules are
  missing), tutorials, and other human written text is up-to-date with any changes in the code.
• Installation instructions in the README, documentation and on the website (e.g., diffpy.org) are updated and
  tested
• Successfully run any tutorial examples or do functional testing in some other way.
• Grammar and writing quality have been checked (no typos).

@sbillinge Ready for review

[sbillinge]

ok, I pushed out 0.4.3rc0 pre-release

[alisnwu]

download successful:

all tests successful using 3.4.3rc0:

parser example:

resample example:

tools example:

@sbillinge ready for full release

[bobleesj]

@alisnwu rc version is a pre-release version - lets re-open this issue and wait for @sbillinge to do full release

[bobleesj]

have you tried examples or getting started?

[alisnwu]

Yes updated the comment for review

[sbillinge]

OK, I pushed out the main release. No need to do the conda-forge workflow on this one, we will work on 3.5.0 and push that one all the way up.

[sbillinge]

@alisnwu just build a test env and pip install then run the tests and if all is ok you can close this issue, update mission-control and add a delivery to your group meeting slides....

[alisnwu]

download successful:

pytest passed:

parsers and tools example passed:

Closing this issue