Conversation
Goooler
commented
Jul 2, 2025
Comment on lines
-35
to
+36
| ORG_GRADLE_PROJECT_nexus_user: ${{ secrets.NEXUS_USER }} | ||
| ORG_GRADLE_PROJECT_nexus_pass64: ${{ secrets.NEXUS_PASS64 }} | ||
| ORG_GRADLE_PROJECT_central_portal_user: ${{ secrets.CENTRAL_PORTAL_USER }} | ||
| ORG_GRADLE_PROJECT_central_portal_pass64: ${{ secrets.CENTRAL_PORTAL_PASS64 }} |
Member
Author
There was a problem hiding this comment.
It's worthwhile to add new secrets and remove the old ones to clearly distinguish between them.
e.g. GradleUp/shadow#1414.
Member
There was a problem hiding this comment.
I think you are correct that this is the good thing to do. But because DiffPlug has a central repository where all the rest of our builds pull from
it saves me a bit of time to keep the old names. Just FYI, I reverted to the old cred names (with updated values) in the commit referenced at the bottom of this PR.
Member
Author
|
This is required before releasing the next versions, as OSSRH is down. |
Member
|
Thanks so much @Goooler, this would have taken me a while to figure out. |
nedtwigg
pushed a commit
that referenced
this pull request
Jul 8, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://central.sonatype.org/news/20250326_ossrh_sunset/
https://github.com/gradle-nexus/publish-plugin?tab=readme-ov-file#publishing-to-maven-central-via-sonatype-central