feat: Use arm64 pic binaries#268
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the PocketIC binary download logic to support arm64, and refactors the nns_proxy example tests to stop relying on a pre-initialized NNS state archive by using PocketIC’s native NNS setup + ICP feature configuration.
Changes:
- Add arch-aware platform selection for downloading the correct PocketIC binary (arm64 vs x86_64).
- Remove repo-level NNS state archive extraction and switch
nns_proxytests toSubnetStateType.New+icpFeatures-based NNS/ledger setup. - Remove the hard-coded “minter” test identity and mint test funds from the anonymously-seeded ICP ledger instead.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| packages/pic/postinstall.mjs | Selects PocketIC download artifact based on CPU architecture. |
| package.json | Removes state-archive extraction from scripts; simplifies setup. |
| examples/nns_proxy/tests/src/support/ledger.ts | Mints funds by transferring from the anonymously seeded ICP balance. |
| examples/nns_proxy/tests/src/support/identity.ts | Deletes hard-coded minter key material used for minting in tests. |
| examples/nns_proxy/tests/src/support/governance.ts | Parameterizes neuron stake and adjusts mint/stake amounts for neuron creation. |
| examples/nns_proxy/tests/src/nns-proxy.spec.ts | Uses fresh NNS state + enables required ICP features; adds “ballast” neuron approach. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
lwshang
previously approved these changes
Jun 5, 2026
lwshang
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since arm64 and x64 seem to have incompatible state archives, replaces the preinitialized state in tests with PocketIC's native feature for setting up the NNS.