Skip to content

feat: Use arm64 pic binaries#268

Merged
adamspofford-dfinity merged 5 commits into
mainfrom
spofford/arm
Jun 8, 2026
Merged

feat: Use arm64 pic binaries#268
adamspofford-dfinity merged 5 commits into
mainfrom
spofford/arm

Conversation

@adamspofford-dfinity

Copy link
Copy Markdown
Contributor

Since arm64 and x64 seem to have incompatible state archives, replaces the preinitialized state in tests with PocketIC's native feature for setting up the NNS.

Copilot AI review requested due to automatic review settings June 5, 2026 19:52
@adamspofford-dfinity adamspofford-dfinity requested a review from a team as a code owner June 5, 2026 19:52

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the PocketIC binary download logic to support arm64, and refactors the nns_proxy example tests to stop relying on a pre-initialized NNS state archive by using PocketIC’s native NNS setup + ICP feature configuration.

Changes:

  • Add arch-aware platform selection for downloading the correct PocketIC binary (arm64 vs x86_64).
  • Remove repo-level NNS state archive extraction and switch nns_proxy tests to SubnetStateType.New + icpFeatures-based NNS/ledger setup.
  • Remove the hard-coded “minter” test identity and mint test funds from the anonymously-seeded ICP ledger instead.

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
packages/pic/postinstall.mjs Selects PocketIC download artifact based on CPU architecture.
package.json Removes state-archive extraction from scripts; simplifies setup.
examples/nns_proxy/tests/src/support/ledger.ts Mints funds by transferring from the anonymously seeded ICP balance.
examples/nns_proxy/tests/src/support/identity.ts Deletes hard-coded minter key material used for minting in tests.
examples/nns_proxy/tests/src/support/governance.ts Parameterizes neuron stake and adjusts mint/stake amounts for neuron creation.
examples/nns_proxy/tests/src/nns-proxy.spec.ts Uses fresh NNS state + enables required ICP features; adds “ballast” neuron approach.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread packages/pic/postinstall.mjs
Comment thread examples/nns_proxy/tests/src/support/governance.ts
Comment thread examples/nns_proxy/tests/src/nns-proxy.spec.ts
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
lwshang
lwshang previously approved these changes Jun 5, 2026
@adamspofford-dfinity adamspofford-dfinity added this pull request to the merge queue Jun 8, 2026
Merged via the queue into main with commit 72f6000 Jun 8, 2026
15 checks passed
@adamspofford-dfinity adamspofford-dfinity deleted the spofford/arm branch June 8, 2026 15:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants