feat: Allow specifying PIC version#266
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR enhances @dfinity/pic’s postinstall flow by letting consumers pin which PocketIC binary version to download (via a .pocket-ic-version file in the invoking project) and by extending platform detection to support arm64 binaries.
Changes:
- Add support for reading a
package:<version>oric:<version>spec from.pocket-ic-versionto choose the download source/version. - Extend platform detection to download
arm64-*binaries when running on arm64/aarch64. - Refactor the download URL computation into a helper (
resolveDownloadUrl()).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
fc14bb5 to
71e14b6
Compare
lwshang
previously approved these changes
Jun 5, 2026
lwshang
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds support for reading the binary version from a .pocket-ic-version file. The version string goes
ic:<version>orpackage:<version>based on whether it should be read from the dfinity/ic or dfinity/pocketic repos. This allows you to use bleeding edge features ahead of official pocket-ic releases.