Skip to content

chore: remove extra word in comment#10304

Merged
alin-at-dfinity merged 1 commit into
dfinity:masterfrom
caltechustc:master
May 27, 2026
Merged

chore: remove extra word in comment#10304
alin-at-dfinity merged 1 commit into
dfinity:masterfrom
caltechustc:master

Conversation

@caltechustc

Copy link
Copy Markdown
Contributor

remove extra word in comment

Signed-off-by: caltechustc <caltechustc@outlook.com>
@caltechustc caltechustc requested review from a team as code owners May 23, 2026 12:36
@github-actions github-actions Bot added the chore label May 23, 2026

@github-actions github-actions Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This pull request changes code owned by the Governance team. Therefore, make sure that
you have considered the following (for Governance-owned code):

  1. Update unreleased_changelog.md (if there are behavior changes, even if they are
    non-breaking).

  2. Are there BREAKING changes?

  3. Is a data migration needed?

  4. Security review?

How to Satisfy This Automatic Review

  1. Go to the bottom of the pull request page.

  2. Look for where it says this bot is requesting changes.

  3. Click the three dots to the right.

  4. Select "Dismiss review".

  5. In the text entry box, respond to each of the numbered items in the previous
    section, declare one of the following:

  • Done.

  • $REASON_WHY_NO_NEED. E.g. for unreleased_changelog.md, "No
    canister behavior changes.", or for item 2, "Existing APIs
    behave as before.".

Brief Guide to "Externally Visible" Changes

"Externally visible behavior change" is very often due to some NEW canister API.

Changes to EXISTING APIs are more likely to be "breaking".

If these changes are breaking, make sure that clients know how to migrate, how to
maintain their continuity of operations.

If your changes are behind a feature flag, then, do NOT add entrie(s) to
unreleased_changelog.md in this PR! But rather, add entrie(s) later, in the PR
that enables these changes in production.

Reference(s)

For a more comprehensive checklist, see here.

GOVERNANCE_CHECKLIST_REMINDER_DEDUP

@cla-idx-bot

cla-idx-bot Bot commented May 23, 2026

Copy link
Copy Markdown

Dear @caltechustc,

In order to potentially merge your code in this open-source repository and therefore proceed with your contribution, we need to have your approval on DFINITY's CLA.

If you decide to agree with it, please visit this issue and read the instructions there. Once you have signed it, re-trigger the workflow on this PR to see if your code can be merged.

— The DFINITY Foundation

@caltechustc

Copy link
Copy Markdown
Contributor Author

re-trigger

@caltechustc

Copy link
Copy Markdown
Contributor Author

Thanks!

@github-actions

Copy link
Copy Markdown
Contributor

@alin-at-dfinity alin-at-dfinity added this pull request to the merge queue May 27, 2026
Merged via the queue into dfinity:master with commit 353ba4b May 27, 2026
25 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants