fix: handle offset views correctly#40
Merged
Merged
Conversation
nathanosdev
commented
Jun 17, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It's possible for a consumer to pass in a
Uin8Arraythat is pointing at some offset of the underlyingArrayBuffer. This is fine for most of the code in this library, except when we create our ownDataViewon the underlyingArrayBuffer. Previously we were creating thatDataViewat the0index of the underlyingArrayBuffer, now we create it atUint8Array.offsetinstead to ensure we do not read the wrong indexes.