ci: release didc via cargo-dist; split candid_ui into its own workflow#745
Merged
Conversation
Replace the hand-written release.yml with a two-track release setup: - didc binaries are now built and published by cargo-dist (dist 0.31.0, matching ic-wasm) on `didc-vX.Y.Z` SemVer tags. Targets: linux x86_64, linux x86_64-musl, linux arm64, macOS x86_64, macOS arm64. arm32 is dropped as it is not a cargo-dist-supported target. Config lives in dist-workspace.toml; the workflow (didc-release.yml) is generated via `dist generate`. Third-party actions are SHA-pinned. - candid_ui.wasm keeps the repo's date-based tag (YYYY-MM-DD) trigger in the new candid-ui.yml, preserving the asset name that icp-cli pins. Add the package metadata cargo-dist needs to tools/didc/Cargo.toml and a [profile.dist] to the workspace, and document the new release process. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR modernizes the repository’s release automation by migrating didc binary releases to cargo-dist while splitting the candid_ui.wasm release into its own dedicated workflow, keeping the existing date-tag release behavior for the wasm artifact.
Changes:
- Replace the monolithic tag-triggered
release.ymlwith a cargo-dist generateddidc-release.ymldriven bydidc-vX.Y.Ztags anddist-workspace.toml. - Add a standalone
candid-ui.ymlworkflow that continues releasingcandid_ui.wasmon date-based tags (YYYY-MM-DD). - Update crate metadata and documentation to reflect the new two-track release process.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| tools/didc/Cargo.toml | Adds missing crate metadata (description/license/repository) needed for distribution tooling. |
| README.md | Documents the new two-track release process and tag conventions. |
| dist-workspace.toml | Introduces cargo-dist configuration (targets, tag namespace, SHA-pinned actions). |
| Cargo.toml | Adds a profile.dist used by cargo-dist builds. |
| .github/workflows/release.yml | Removes the old combined release workflow. |
| .github/workflows/didc-release.yml | Adds the cargo-dist generated didc release workflow. |
| .github/workflows/candid-ui.yml | Adds a dedicated workflow to publish candid_ui.wasm on date tags. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Click to see raw report |
Addresses Copilot review: the lockfiles are committed, so honor them in the release build (npm ci instead of npm install, cargo --locked). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
adamspofford-dfinity
approved these changes
Jun 25, 2026
|
✅ No security or compliance issues detected. Reviewed everything up to c0ce7fa. Security Overview
Detected Code Changes| Change Type | Relevant files ... (code changes summary truncated to fit VCS comment limits.) |
This was referenced Jun 25, 2026
lwshang
added a commit
that referenced
this pull request
Jun 25, 2026
## Summary `Nat`/`Int` encode and decode processed values one LEB128/SLEB128 group at a time, shifting or OR-ing the whole bignum on every byte — O(n²) in the encoded length once a value exceeds the `u64`/`i64` fast path. This rebuilds the value in a single pass instead, making all four paths O(n). - **decode**: collect the 7-bit groups and construct the bignum once via `BigUint::from_radix_le(_, 128)` (radix 128 is a power of two, so this bit-packs in O(n)); `Int` additionally reinterprets the two's-complement sign. - **encode**: emit groups via `BigUint::to_radix_le(128)` for `Nat`, and repack the minimal two's-complement bytes into SLEB128 groups for `Int`. The `u64`/`i64` fast paths are unchanged. ## Impact All four paths were O(n²) before this PR. Measured with `canbench` on a 1 MiB encoded value, after the fix: | path | instructions | |------|-------------:| | `Nat` encode | 66.5 M | | `Nat` decode | 189 M | | `Int` encode | 285 M | | `Int` decode | 191 M | For reference, before the fix the encode side alone measured **1.93 T** (`Nat`) and **3.85 T** (`Int`) for the same input — a ~29,000× / ~13,500× reduction; decode had the same O(n²) shape. ## Tests - New boundary, large-value, all-`0x7f`, large-negative, and a randomized roundtrip (1000 values, both signs) covering the bignum encode/decode paths. - Existing exact-byte and random fast-path tests still pass (`cargo test -p candid --all-features`). ## Bench - Adds `nat_bignum` / `int_bignum` to the `canbench` suite (`rust/bench`). ## Release This PR carries the version bumps and CHANGELOG entries for two releases to be cut **once it merges**: - **`candid` / `candid_derive` → 0.10.31** (the perf change above), plus the workspace and bench lockfile refreshes. - **`didc` → 0.6.2** — picks up `candid_parser` 0.4.0. ### Release steps after merge 1. **candid 0.10.31** — run the existing `publish.yml` workflow (`workflow_dispatch`) with the **candid** input checked. It publishes `candid_derive` then `candid` to crates.io. 2. **didc 0.6.2** — push a `didc-v0.6.2` tag. This triggers the new `didc-release.yml` (cargo-dist) workflow added in #745 — building/publishing the `didc` binaries for the 5 supported targets and creating the GitHub Release. This will be the **first real exercise of that workflow** (so far it has only run in `pull_request` dry-run mode). `dist plan` against this branch confirms it resolves `didc 0.6.2` with the expected artifacts. --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replaces the hand-written
release.ymlwith a two-track release setup, mirroring the ic-wasm cargo-dist migration.didcbinaries → cargo-dist0.31.0(same version as ic-wasm) ondidc-vX.Y.ZSemVer tags.x86_64-unknown-linux-gnu,x86_64-unknown-linux-musl(static),aarch64-unknown-linux-gnu,x86_64-apple-darwin,aarch64-apple-darwin.dist-workspace.toml; the workflowdidc-release.ymlis generated viadist generate(don't hand-edit — regenerate after config changes).[dist.github-action-commits].candid_ui.wasm→ its own workflowcandid_ui.wasmis pinned downstream by icp-cli at a date-tag URL. So it keeps the repo's date-based tag (YYYY-MM-DD) trigger, now in the newcandid-ui.yml, producing the same asset name.tag-namespace = "didc"scopes the cargo-dist workflow todidc-v*tags, so the two triggers never collide.didcnow releases on a SemVer tag (didc-v0.6.1) instead of the date tag; date tags now release onlycandid_ui.wasm. README updated.didc-<target-triple>.tar.xzarchives +didc-installer.sh+sha256.suminstead of raw binaries nameddidc-linux64/didc-macos/didc-arm32. Confirmed nothing in sdk/icp-cli hardcodes the old names and the README only links to the releases page generically.arm-unknown-linux-gnueabihfis not a cargo-dist-supported target. Can be re-added later as a separate cross-build side-job if needed.Validation
dist planis clean: onlydidc0.6.1, the 5 targets above.cargo metadataparses; both workflows are valid YAML.release.ymlbinary smoke-test is already covered bytools.yml'sbuild-didcjob.Out of scope
npm packaging of
didc(ic-wasm hasrelease-npm.yml+npm/; candid has no equivalent today).🤖 Generated with Claude Code