perf: skip tokenizer trivia bookkeeping without trivia#713
Merged
Conversation
Avoid comment and line-tracking work when parsers do not capture trivia. This trims successful DID and arg parsing on the hot path without changing the trivia-enabled behavior. Refs #710
Click to see raw report |
lwshang
approved these changes
Mar 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Reduce parser work on tokenizer paths that do not capture trivia.
Requirements
Keep comment and doc-comment behavior unchanged when trivia capture is enabled.
Solution
Skip comment and line-tracking bookkeeping when the tokenizer runs without trivia capture. This trims successful DID and argument parsing on the hot path without changing the trivia-enabled path.
Considerations
Parser behavior with trivia capture is unchanged, and the parser test suite still passes. Series-level benchmark context is tracked in #710.