perf: avoid cloning record fields during decode#711
Merged
Conversation
Track record decode progress with shared type metadata and indices so struct and tuple decoding stop rebuilding field queues for every value.
Click to see raw report |
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
lwshang
approved these changes
Mar 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
Reduce per-record allocation churn during Candid record decoding.
Requirements
Preserve existing wire compatibility and keep record decoding behavior unchanged.
Solution
Track expected and wire record fields by type plus index instead of cloning field queues for each decoded record. Add a compatibility test covering backward and forward compatible record vectors.
Considerations
This keeps the wire format unchanged and is intended to remain fully compatible with existing Candid data. Series-level benchmark context is tracked in #710.