Skip to content

Suggest full url from child manifest #686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
spoorcc merged 1 commit into from
Mar 9, 2025
Merged

Suggest full url from child manifest #686

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ Release 0.10.0 (unreleased)

* Support python 3.13
* Fix too strict overlapping path check (#684)
* Show complete URL of child manifests (#683)

Release 0.9.1 (released 2024-12-31)
===================================
Expand Down
4 changes: 4 additions & 0 deletions dfetch/manifest/project.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -426,6 +426,10 @@ def as_recommendation(self) -> "ProjectEntry":
recommendation = self.copy(self)
recommendation._dst = "" # pylint: disable=protected-access
recommendation._patch = "" # pylint: disable=protected-access
recommendation._url = self.remote_url # pylint: disable=protected-access
recommendation._remote = "" # pylint: disable=protected-access
recommendation._remote_obj = None # pylint: disable=protected-access
recommendation._repo_path = "" # pylint: disable=protected-access
return recommendation

def as_yaml(self) -> Dict[str, str]:
Expand Down
10 changes: 10 additions & 0 deletions features/checked-project-has-dependencies.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,10 +48,17 @@ Feature: Check for dependencies in projects
"""
manifest:
version: 0.0
remotes:
- name: github-com-dfetch-org
url-base: https://github.com/dfetch-org/test-repo

projects:
- name: SomeOtherProject
url: some-remote-server/SomeOtherProject.git
tag: v1

- name: ext/test-repo-tag-v1
tag: v1
"""
And a git repository "SomeOtherProject.git"
And all projects are updated in MyProject
Expand All @@ -68,6 +75,9 @@ Feature: Check for dependencies in projects
- name: SomeOtherProject
url: some-remote-server/SomeOtherProject.git
tag: v1
- name: ext/test-repo-tag-v1
url: https://github.com/dfetch-org/test-repo
tag: v1
"""

Scenario: No recommendation is done
Expand Down
10 changes: 10 additions & 0 deletions features/updated-project-has-dependencies.feature
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,11 +23,18 @@ Feature: Updated project has dependencies
"""
manifest:
version: 0.0
remotes:
- name: github-com-dfetch-org
url-base: https://github.com/dfetch-org/test-repo

projects:
- name: SomeOtherProject
dst: SomeOtherProject
url: some-remote-server/SomeOtherProject.git
tag: v1

- name: ext/test-repo-tag-v1
tag: v1
"""
And a git repository "SomeProjectWithoutChild.git"
When I run "dfetch update" in MyProject
Expand All @@ -42,6 +49,9 @@ Feature: Updated project has dependencies
- name: SomeOtherProject
url: some-remote-server/SomeOtherProject.git
tag: v1
- name: ext/test-repo-tag-v1
url: https://github.com/dfetch-org/test-repo
tag: v1

SomeProjectWithoutChild: Fetched v1
"""
Expand Down