Skip to content

Remove SSH access configuration from EKS node groups and related variables - #2435

Open
avnes wants to merge 3 commits into
masterfrom
feature/remove-ssh-access-to-nodes
Open

Remove SSH access configuration from EKS node groups and related variables#2435
avnes wants to merge 3 commits into
masterfrom
feature/remove-ssh-access-to-nodes

Conversation

@avnes

@avnes avnes commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

WARNING: DO NOT MERGE UNTIL RIGHT BEFORE DEPLOYMENT. NODES ROLLOVER WILL HAPPEN!

Describe your changes

  • Update pre-commit-terraform to v1.108.1
  • Remove SSH access configuration from EKS node groups and related variables

Checklist before requesting a review

Is it a new release?

  • Apply a release tag release:(major|minor|patch), following semantic versioning in this guide or norelease if there is no changes to the Terraform code

@avnes
avnes requested a review from a team as a code owner August 5, 2026 09:26
@avnes avnes added the release:major Triggers a major release label Aug 5, 2026
@DFDS-Snyk

DFDS-Snyk commented Aug 5, 2026

Copy link
Copy Markdown

Snyk checks have passed. No issues have been found so far.

Status Scan Engine Critical High Medium Low Total (0)
Open Source Security 0 0 0 0 0 issues
Licenses 0 0 0 0 0 issues
Code Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

Comment thread compute/eks-ec2/main.tf

@wcarlsen wcarlsen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove the ec2-keypair module, since it is most likely not used anywhere else?

@avnes
avnes requested a review from wcarlsen August 5, 2026 10:52
@wcarlsen

wcarlsen commented Aug 5, 2026

Copy link
Copy Markdown
Contributor

@wcarlsen wcarlsen left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine and great catch BTW. Thanks!

@avnes

avnes commented Aug 5, 2026

Copy link
Copy Markdown
Contributor Author

@wcarlsen after I have looked at your PRs, and approved, I second your opinion about merging them into one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

on-hold release:major Triggers a major release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants