Remove SSH access configuration from EKS node groups and related variables - #2435
Open
avnes wants to merge 3 commits into
Open
Remove SSH access configuration from EKS node groups and related variables#2435avnes wants to merge 3 commits into
avnes wants to merge 3 commits into
Conversation
✅ Snyk checks have passed. No issues have been found so far.
💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse. |
wcarlsen
reviewed
Aug 5, 2026
wcarlsen
requested changes
Aug 5, 2026
wcarlsen
left a comment
Contributor
There was a problem hiding this comment.
Remove the ec2-keypair module, since it is most likely not used anywhere else?
Contributor
|
This PR falls in the same category as these:
since they all will cause a node rollover, so maybe we should bundle them together. |
wcarlsen
approved these changes
Aug 5, 2026
wcarlsen
left a comment
Contributor
There was a problem hiding this comment.
This looks fine and great catch BTW. Thanks!
Contributor
Author
|
@wcarlsen after I have looked at your PRs, and approved, I second your opinion about merging them into one. |
This was referenced Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WARNING: DO NOT MERGE UNTIL RIGHT BEFORE DEPLOYMENT. NODES ROLLOVER WILL HAPPEN!
Describe your changes
Checklist before requesting a review
test/integrationfolder to apply my changes in QA. Read the guide on adding environment variables in QAIs it a new release?
release:(major|minor|patch), following semantic versioning in this guide ornoreleaseif there is no changes to the Terraform code