Fix UpdateBBs for rotated entities#324
Merged
dexyfex merged 1 commit intodexyfex:masterfrom Apr 8, 2025
Merged
Conversation
• Correct bounding boxes for rotating entities • Correct rotation around the center of the entity
Contributor
Author
|
Before |
kirill-mapper
added a commit
to kirill-mapper/CodeWalker
that referenced
this pull request
Apr 19, 2025
Fixed bounding box calculation to properly account for object rotation. The previous dexyfex#324 solution had two issues: Incorrect rotation direction - fixed by using inverted quaternion (Quaternion.Invert) Redundant operations with bounding box center - simplified transformation formula to standard "rotation + translation" Now the bounding box correctly considers object rotation in space.
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
• Correct bounding boxes for rotating entities
• Correct rotation around the center of the entity