perf(terminal): differentiated scrollback for grid cards - #60
Merged
Conversation
…cards A 10k-row scrollback costs ~3 MB per terminal; with every open session keeping a live xterm, 20 sessions in grid hold ~64 MB of scrollback alone. Grid cards are thumbnails and only need recent context. createTerminalEntry now defaults scrollback by view mode (explicit opts.scrollback wins); showGridView drops live cards to the thumbnail budget (xterm trims immediately — documented trade-off); showSession restores the full budget when a session returns to single view.
… just the focused one Review finding (MAJOR, pr56-review): background sessions kept producing output after the grid closed but stayed silently capped at the thumbnail budget until individually shown. Harness now loads grid-view.js (+ its shortcuts.js dependency) so hideGridView is testable.
abasiri
pushed a commit
that referenced
this pull request
Aug 1, 2026
…g missing (#60) The only full disk scan (populateCacheViaWorker) runs solely when the cache is completely empty, so a project folder that changed while the app was closed — or that predates the build which first indexed it — was never picked up, and its sessions silently vanished from the sidebar. Replaces the unused populateCacheFromFilesystem with reconcileCacheFromFilesystem, which re-indexes only folders that are new or whose newest .jsonl is newer than the recorded indexMtimeMs, and calls it from the get-projects handler. The gate is stat-only, so it is cheap when nothing changed. Co-authored-by: ymajoros <yannick@valuya.be>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #56 (auto-closed by GitHub when #55's base branch was deleted — could not be reopened). Same content, rebased onto main, including the review fix from
pr56-review.md:hideGridViewnow restores the full scrollback budget for ALL open sessions (background sessions kept producing output silently capped at 1000 rows).Original description: see #56. Review verdict after fix: MERGE.
task checkgreen — 201/201 at this commit.