polish(reconcile): throttle back-to-back sweeps, document the sync call site - #38
Merged
Merged
Conversation
…ll site Review follow-ups: loadProjects() fires get-projects twice per sidebar paint (showArchived false/true), running the reconcile sweep back-to-back; a 1s throttle skips the redundant second pass while the live watcher covers anything landing inside the window. Also note at the call site that the reconcile is synchronous, so the missing await next to the cold-start branch's 'await populateCacheViaWorker()' is intentional.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #29 — the two non-blocking review notes:
reconcileCacheFromFilesystem:loadProjects()firesget-projectstwice per sidebar paint (showArchivedfalse/true viaPromise.all), running the stat sweep back-to-back. The second pass was idempotent but wasted; anything landing inside the window is covered by the live watcher.awaitnext to the cold-start branch'sawait populateCacheViaWorker()is intentional.task checkgreen on the exact diff (lint + full suite).