Skip to content

Conversation

@demetris-manikas
Copy link

**What issue type does this pull request address?
/kind feature

What does this pull request do? Which issues does it resolve? (use resolves #<issue_number> if possible)
resolves #2923

Please provide a short message that should be published in the DevSpace release notes
Allow users to toggle the visibility of internal commands in the ui

What else do we need to know?

@netlify
Copy link

netlify bot commented Feb 14, 2025

Deploy Preview for devspace-docs ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit 339d925
🔍 Latest deploy log https://app.netlify.com/sites/devspace-docs/deploys/67dd866b0e9b8c00089fea27
😎 Deploy Preview https://deploy-preview-2937--devspace-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

};

render() {
let commands = this.props.devSpaceConfig.config.commands;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I checked out your branch, fired it up and got the folllowing errors in the console, preventing the page to load

ds-console-error

Copy link
Author

@demetris-manikas demetris-manikas Feb 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that.
Trusting typescript is always dodgy.

Give it another try.

Demetris Manikas added 2 commits February 20, 2025 19:56
@demetris-manikas demetris-manikas force-pushed the 2923-ui-toggle-internal-commands-visibility branch from 33869b3 to aba7119 Compare February 20, 2025 17:56
@demetris-manikas
Copy link
Author

Hi.
Thanks for giving devspace to the world.
It is a great product.
It seems that you either have no time or no interest in this.
I thought you asked for a PR because you wanted people to get involved.
Ignoring for so long does not help.
The changes are minimal.
If you wish you can take it from here.
I won't bother with matter any longer.
Thanks

Copy link
Collaborator

@zerbitx zerbitx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Got a chance to test this out this morning.

@zerbitx zerbitx merged commit 83abc79 into devspace-sh:main Mar 21, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

The ui shows internal commands when it maybe shouldn't

2 participants