Skip to content

real-time churn prediction with automl and superset#7

Open
sabrinaaquino wants to merge 4 commits intomainfrom
sabrinaaquino-patch-1
Open

real-time churn prediction with automl and superset#7
sabrinaaquino wants to merge 4 commits intomainfrom
sabrinaaquino-patch-1

Conversation

@sabrinaaquino
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown
Contributor

@stella-ds stella-ds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In inference.ipynb
def download_model() function is calling download_from_cloud which doesn't exist, need to change it to s3fs.get() or import utils

example_notebooks/Churn-Prediction/pipeline.yaml change the script to the inference.ipynb

readme is the datadownloadable there?

in train.ipynb remove the write to superset part

using the s3fs library to download the model from the S3 bucket
Copy link
Copy Markdown
Contributor Author

@sabrinaaquino sabrinaaquino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

addressed the issues:

"def download_model() function is calling download_from_cloud which doesn't exist, need to change it to s3fs.get() or import utils

example_notebooks/Churn-Prediction/pipeline.yaml change the script to the inference.ipynb

in train.ipynb remove the write to superset part"

@stella-ds
Copy link
Copy Markdown
Contributor

@sabrinaaquino could you please address the following

  • change 'postgresql://superset:superset@example/superset' to os.environ['SUPERSET_HOST_URL']
  • put the folder under the folder blog/
  • hide the output of the pip install cell in the notebooks
  • remove redundant cells like # pip install --upgrade numpy
  • add text under Split to Train/Test disclaim that this is an naive way of spliting the train test for demo purposes.
  • remove the function upload_to_cloud use just the line for s3 because it's not an useful function for this demo

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants