This repository was archived by the owner on Jul 21, 2019. It is now read-only.
Images not resolving in early static events.#665
Merged
Conversation
It looks like the images that were in these files weren't being copied across from /public -> /dist when ./netlify-production.sh ran the gulp task to copy stuff across. Signed-off-by: Chris M <millscj01@gmail.com>
Contributor
|
Thanks, Chris! I know @mattstratton is planning a release soon - likely this is something he'll want to consider getting in! |
Member
|
I'll merge this in - we have to "manually" make this change into |
mattstratton
added a commit
to devopsdays/devopsdays-web
that referenced
this pull request
Oct 15, 2018
mattstratton
added a commit
to devopsdays/devopsdays-web
that referenced
this pull request
Oct 15, 2018
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should fix #662
Looks like the gulp task which copied old images from /public/events/2016-minneapolis/speakers/ wasn't copying them across to /dist/events/2016/minneapolis/speakers/ causing the images to be broken.
I spun up an example of the 'fixed' example of this here: https://mystifying-goodall-173afa.netlify.com/events/2016-minneapolis/speakers/aj-bowen.jpg using the same problematic image.
This change is