Draft
Conversation
- refactored GitContextImpl
Collaborator
Pull Request Test Coverage Report for Build 14462897556Details
💛 - Coveralls |
mbilda
commented
Apr 22, 2025
|
|
||
| ProcessResult result = runGitCommand(directory, ProcessMode.DEFAULT, args); | ||
| private void handleErrors(Path repository, ProcessResult result, String errorMessage) { | ||
| if (!result.isSuccessful()) { |
Contributor
Author
There was a problem hiding this comment.
This if clause is relevant to decide if the result was an error or not. If it wasn't an error, we don't need to "handle Errors". We should consider this if-check in the "parent" method or wherever it is called.
mbilda
commented
Apr 22, 2025
| warningOnError += " - Expected single line of output but received " + size + " lines from " + result.getCommand(); | ||
| } | ||
| private void requireOnline(String action) { | ||
| if (this.context.isOfflineMode()) { |
Contributor
Author
There was a problem hiding this comment.
Same es above. If we check if its offlineMode, then we don't need to check if its required to be online.
Contributor
Author
There was a problem hiding this comment.
Need to be analyzed in detail, because isOfflineMode and requireOnline could be two different things to consider.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes: #1205