Skip to content
/ stream Public
generated from devnw/oss-template

feat(scaler.go): add max routine support to scaler#31

Merged
benjivesterby merged 6 commits intomainfrom
max-pool
Mar 29, 2023
Merged

feat(scaler.go): add max routine support to scaler#31
benjivesterby merged 6 commits intomainfrom
max-pool

Conversation

@benjivesterby
Copy link
Member

@benjivesterby benjivesterby commented Mar 27, 2023

No description provided.

This change also removes the mutexes that were guarding the step int for now
@benjivesterby benjivesterby linked an issue Mar 27, 2023 that may be closed by this pull request
@codecov
Copy link

codecov bot commented Mar 27, 2023

Codecov Report

Patch coverage: 83.33% and project coverage change: -0.02 ⚠️

Comparison is base (2873556) 93.26% compared to head (17e2d6d) 93.24%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #31      +/-   ##
==========================================
- Coverage   93.26%   93.24%   -0.02%     
==========================================
  Files           3        3              
  Lines         282      311      +29     
==========================================
+ Hits          263      290      +27     
- Misses         15       17       +2     
  Partials        4        4              
Impacted Files Coverage Δ
scaler.go 88.81% <83.33%> (-2.85%) ⬇️

... and 1 file with indirect coverage changes

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@github-actions
Copy link
Contributor

Fuzz test failed on 8f47c84. Using the GitHub CLI, download the seed corpus with

gh run download 4537736157 -n testdata

1 similar comment
@github-actions
Copy link
Contributor

Fuzz test failed on 8f47c84. Using the GitHub CLI, download the seed corpus with

gh run download 4537736157 -n testdata

@benjivesterby benjivesterby marked this pull request as ready for review March 28, 2023 10:04
@gitstream-cm
Copy link

gitstream-cm bot commented Mar 28, 2023

👋 Suggested reviewers: no user matched

No other user contributed more than 25% of the lines on pre-existing files:

See details

scaler.go
benjivesterby: 100%

scaler_test.go
benjivesterby: 100%

To learn more about /:\ gitStream - Visit our Docs

@benjivesterby benjivesterby merged commit 4e39194 into main Mar 29, 2023
@benjivesterby benjivesterby deleted the max-pool branch March 29, 2023 00:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

[Feat]: Add configuration for max routines

2 participants