-
Notifications
You must be signed in to change notification settings - Fork 459
Fix iPhone Air camera specification to wide-only #477
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The iPhone Air only has a 48MP Fusion Main camera (wide), not an ultra-wide camera. Changed camera value from 13 (wide + ultraWide) to 1 (wide only) in Device.swift.gyb and regenerated Device.generated.swift. Co-authored-by: Zandor300 <[email protected]>
Zandor300
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please rebase on master and regenerate the swift file using new instructions.
Updated to use the new GYB command: ./Utils/gyb --line-directive '' -o ./Source/Device.generated.swift ./Source/Device.swift.gyb Fix remains: iPhone Air camera value changed from 13 to 1 (wide only). Co-authored-by: Zandor300 <[email protected]>
Co-authored-by: Zandor300 <[email protected]>
Rebased on master and regenerated the Swift file using the new GYB command ( |
|
@copilot Please add a changelog entry. |
Co-authored-by: Zandor300 <[email protected]>
SwiftLint found issuesWarnings
Generated by 🚫 Danger |
Co-authored-by: Zandor300 <[email protected]>
iPhone Air was incorrectly marked as having an ultra-wide camera. Per Apple specs, it only has a 48MP Fusion Main (wide) camera—no ultra-wide.
Changes Made
Device.swift.gybfrom13(wide + ultraWide) to1(wide only)Device.generated.swiftusing new GYB command__pycache__to.gitignoreResult
iPhone Air is also removed from
allDevicesWithUltraWideCamera.Fixes #463
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.