Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Dec 2, 2025

iPhone Air was incorrectly marked as having an ultra-wide camera. Per Apple specs, it only has a 48MP Fusion Main (wide) camera—no ultra-wide.

Changes Made

  • Updated camera value in Device.swift.gyb from 13 (wide + ultraWide) to 1 (wide only)
  • Regenerated Device.generated.swift using new GYB command
  • Added __pycache__ to .gitignore
  • Added changelog entry under new "Unreleased" section

Result

// Before
Device.iPhoneAir.cameras  // [.wide, .ultraWide]
Device.iPhoneAir.hasUltraWideCamera  // true

// After
Device.iPhoneAir.cameras  // [.wide]
Device.iPhoneAir.hasUltraWideCamera  // false

iPhone Air is also removed from allDevicesWithUltraWideCamera.

Fixes #463

Original prompt

This section details on the original issue you should resolve

<issue_title>iPhone Air marked with ultra-wide camera</issue_title>
<issue_description>The instance of iPhone AIr is currently marked as having Ultra-wide camera, while that not being the case for the device.

Image</issue_description>

Comments on the Issue (you are @copilot in this section)


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

The iPhone Air only has a 48MP Fusion Main camera (wide), not an
ultra-wide camera. Changed camera value from 13 (wide + ultraWide) to
1 (wide only) in Device.swift.gyb and regenerated Device.generated.swift.

Co-authored-by: Zandor300 <[email protected]>
Copilot AI changed the title [WIP] Fix incorrect camera designation for iPhone Air Fix iPhone Air camera specification to wide-only Dec 2, 2025
Copilot AI requested a review from Zandor300 December 2, 2025 06:24
Copy link
Member

@Zandor300 Zandor300 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rebase on master and regenerate the swift file using new instructions.

Copilot AI and others added 2 commits December 2, 2025 06:54
Updated to use the new GYB command:
./Utils/gyb --line-directive '' -o ./Source/Device.generated.swift ./Source/Device.swift.gyb

Fix remains: iPhone Air camera value changed from 13 to 1 (wide only).

Co-authored-by: Zandor300 <[email protected]>
Copy link
Contributor Author

Copilot AI commented Dec 2, 2025

Please rebase on master and regenerate the swift file using new instructions.

Rebased on master and regenerated the Swift file using the new GYB command (./Utils/gyb --line-directive ''). See commit 23ca937.

@Zandor300
Copy link
Member

@copilot Please add a changelog entry.

@github-actions
Copy link

github-actions bot commented Dec 2, 2025

8 Warnings
⚠️ Plist changed, don't forget to localize your plist values
⚠️ Source/Device.generated.swift#L742 - TODOs should be resolved (Replace with proper implementa…).
todo Device.generated.swift:742
⚠️ Source/Device.generated.swift#L1319 - TODOs should be resolved (Replace with proper implementa…).
todo Device.generated.swift:1319
⚠️ Source/Device.generated.swift#L1583 - TODOs should be resolved (Replace with proper implementa…).
todo Device.generated.swift:1583
⚠️ Source/Device.generated.swift#L1761 - TODOs should be resolved (Replace with proper implementa…).
todo Device.generated.swift:1761
⚠️ Source/Device.generated.swift#L1919 - TODOs should be resolved (Replace with proper implementa…).
todo Device.generated.swift:1919
⚠️ Source/Device.generated.swift#L2623 - TODOs should be resolved (Replace with proper implementa…).
todo Device.generated.swift:2623
⚠️ Source/Device.generated.swift#L2684 - TODOs should be resolved (Replace with proper implementa…).
todo Device.generated.swift:2684

SwiftLint found issues

Warnings

File Line Reason
Device.generated.swift 742 TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift 1319 TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift 1583 TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift 1761 TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift 1919 TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift 2623 TODOs should be resolved (Replace with proper implementa...). (todo)
Device.generated.swift 2684 TODOs should be resolved (Replace with proper implementa...). (todo)

Generated by 🚫 Danger

Copy link
Contributor Author

Copilot AI commented Dec 2, 2025

@copilot Please add a changelog entry.

Added changelog entry in commit 3eb1459.

@Zandor300
Copy link
Member

@copilot Please add a changelog entry.

Added changelog entry in commit 3eb1459.

I meant for a new unreleased version. Not add to an existing version.

Copy link
Contributor Author

Copilot AI commented Dec 2, 2025

@copilot Please add a changelog entry.

Added changelog entry in commit 3eb1459.
...

Moved the changelog entry to a new "Unreleased" section at the top. See commit 2506ef6.

@Zandor300 Zandor300 marked this pull request as ready for review December 2, 2025 13:34
@Zandor300 Zandor300 merged commit 3631219 into master Dec 2, 2025
19 checks passed
@Zandor300 Zandor300 deleted the copilot/fix-iphone-air-camera-issue branch December 2, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

iPhone Air marked with ultra-wide camera

2 participants