Tokens are not being hidden according to sight

[ddbrown30]

When a region is set up to limit sight, tokens on either side of the region are still able to see each other. If a token is inside the region, that token will not be able to see other tokens (inside or out) but tokens outside of the region will still be able to see the token inside. I've attached a screenshot to illustrate the issue.

If I instead just create a normal wall and put it between the tokens, they are correctly being hidden so this is definitely an issue with Limits.

If it matters, on v2.0.4 of Limits, 12.331 of Foundry, and I'm using swade (Edit: I just tested on dnd5e and same behaviour). Reproed with no other modules active.

Let me know if you need more info.

[ddbrown30]

Adding another screenshot so you can see what the region looks like.

[ddbrown30]

I'm debugging this a bit and it's coming down the the cast that's triggered by visionSource._testLimit in _testPoint. There aren't many comments to go on so I'm having to piece this together just by reading the code. The failure happens when checking against lightPerception. I see a few problems which means it's likely an issue of me not quite understanding the intent of the code but I'll list them out.

• In _cast, space.minDistance is Infinity. This results in the cast immediately hitting the target.
• Even with that minDistance block commented out, it still doesn't work. CAST.computeHits(this) returns no hits. I'm not sure if the intent here is that this should be returning a hit on the region shape or if it should be returning a hit on the target token. Either way, we skip the for loop which leaves us with currentCost of 0 and remainingEnergy of not 0 which has us set currentTime to 1 which counts as hitting the target.

I imagine this isn't super helpful but it's far as I've made it so far.

[dev7355608]

Thanks for the detailed report. Could you attach the scene JSON export of this scene. I'll take look.

[dev7355608]

It looks like some early test is discarding this region incorrectly for this ray if minDistance is Infinity.

[ddbrown30]

fvtt-Scene-asdasd-UvMGCPIBUs0M8jLT.json

[dev7355608]

Fixed in 2.0.5.