Skip to content

update to serilog 4.1.0#123

Closed
spaasis wants to merge 2 commits into
destructurama:masterfrom
spaasis:master
Closed

update to serilog 4.1.0#123
spaasis wants to merge 2 commits into
destructurama:masterfrom
spaasis:master

Conversation

@spaasis

@spaasis spaasis commented Oct 28, 2024

Copy link
Copy Markdown

The current configuration is giving nuget warnings when using the newer serilog versions

@github-actions github-actions Bot added the tests Pull request that adds new or changes existing tests label Oct 28, 2024
@spaasis

spaasis commented Oct 28, 2024

Copy link
Copy Markdown
Author

I'm not experienced in Serilog internals, but if there's more to here than just a simple package bump, I can try to work something out

@spaasis spaasis marked this pull request as ready for review October 28, 2024 06:19
@github-actions

Copy link
Copy Markdown

This pull request was marked as stale since it has not been active for a long time

@github-actions github-actions Bot added the stale label Nov 28, 2024
@philippedurocher

Copy link
Copy Markdown

Is it possible to merge that PR to make the nuget warning go please? Thank you!

@github-actions github-actions Bot removed the stale label Dec 12, 2024
@sungam3r sungam3r added dependencies Pull requests that update a dependency file and removed tests Pull request that adds new or changes existing tests labels Dec 12, 2024
@sungam3r

Copy link
Copy Markdown
Member

Waiting for #122 and #126.

@sungam3r

Copy link
Copy Markdown
Member

@dependabot rebase

@sungam3r

Copy link
Copy Markdown
Member

Thanks. Replaced by #129.

@sungam3r sungam3r closed this Dec 15, 2024
@codecov

codecov Bot commented Dec 15, 2024

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (88a8732) to head (4649b04).
Report is 7 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff            @@
##            master      #123   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines          239       239           
  Branches        36        36           
=========================================
  Hits           239       239           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants