Skip to content

Adjust tail command to use configurable keep_releases #4177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
andreapozza wants to merge 2 commits into
base: master
Choose a base branch
from
+3 −1
Open

Adjust tail command to use configurable keep_releases #4177

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
70129b6
Adjust tail command to use configurable keep_releases
andreapozza Mar 6, 2026
c94efb7
Change keep_releases to releases_log_limit
andreapozza Mar 6, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion recipe/deploy/release.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,11 @@
return [];
}

$keep_releases = get('releases_log_limit', get('keep_releases', 300));
Copy link
Member

@antonmedv antonmedv Mar 6, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don’t think fallback to keep_releases is appropriate.

Also, we should define it as other variables. with description and comment


$releaseLogs = array_map(function ($line) {
return json_decode($line, true);
}, explode("\n", run('tail -n 300 .dep/releases_log')));
}, explode("\n", run("tail -n $keep_releases .dep/releases_log")));

return array_filter($releaseLogs); // Return all non-empty lines.
});
Expand Down