fix(fs): support for Node.js v20 #6873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6873 +/- ##
==========================================
- Coverage 94.11% 94.11% -0.01%
==========================================
Files 581 581
Lines 42698 42699 +1
Branches 6791 6791
==========================================
Hits 40185 40185
- Misses 2462 2463 +1
Partials 51 51 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
kt3k
reviewed
Nov 19, 2025
fs/_utils.ts
Outdated
| * True if the runtime is Deno, false otherwise. | ||
| */ | ||
| export const isDeno = navigator.userAgent?.includes("Deno"); | ||
| export const isDeno = (globalThis as any).navigator.userAgent?.includes("Deno"); |
Member
There was a problem hiding this comment.
Do we also need ? after navigator, if it's undefined in Node.js v20?
Contributor
Author
There was a problem hiding this comment.
You are right, we need that. fix 9c2b303
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Node.js, navigator is added from v21, so this will cause an error in Node.js v20.x.
This change allows the code to run on Node.js versions newer than Node.js v20.16.0, which added
process.getBuiltinModule.