fix(async): pass numeric value of delay timer to unrefTimer when persistent=false#6822
Merged
kt3k merged 3 commits intodenoland:mainfrom Sep 19, 2025
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #6822 +/- ##
==========================================
- Coverage 94.16% 94.16% -0.01%
==========================================
Files 573 573
Lines 42400 42401 +1
Branches 6732 6732
==========================================
- Hits 39928 39926 -2
- Misses 2422 2424 +2
- Partials 50 51 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
Author
|
I think (?) 368f865 should reliably fix the flaky test from this test (v1.x, macOS-latest) CI run:
|
(Because try...catch...assert doesn't actually verify if an error was thrown)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug was introduced in #6775, as
setArbitraryLengthTimeoutreturns{ valueOf(): number }rather than a primitivenumber, andDeno.unrefTimerthrows if its argument isn't anumber.Previous type checking missed it due to already using a
// @ts-ignorefor the offending line, and the test also missed it due to stubbingDeno.unrefTimerwith a no-op.