Skip to content

Conversation

@crowlKats
Copy link
Member

No description provided.

@crowlKats crowlKats requested a review from kt3k as a code owner July 22, 2025 04:32
@github-actions github-actions bot added the cli label Jul 22, 2025
@codecov
Copy link

codecov bot commented Jul 22, 2025

Codecov Report

Attention: Patch coverage is 97.28507% with 6 lines in your changes missing coverage. Please review.

Project coverage is 94.17%. Comparing base (4db142b) to head (40bb921).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
cli/_prompt_select.ts 97.85% 3 Missing ⚠️
cli/unstable_prompt_multiple_select.ts 93.18% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6769      +/-   ##
==========================================
+ Coverage   94.15%   94.17%   +0.01%     
==========================================
  Files         587      588       +1     
  Lines       42514    42496      -18     
  Branches     6712     6699      -13     
==========================================
- Hits        40030    40020      -10     
+ Misses       2433     2426       -7     
+ Partials       51       50       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kt3k kt3k changed the title refactor: dedupe logic between promptSelect and promptMultipleSelect refactor(cli/unstable): dedupe logic between promptSelect and promptMultipleSelect Jul 22, 2025
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@crowlKats crowlKats merged commit 894fe2c into main Jul 22, 2025
20 checks passed
@crowlKats crowlKats deleted the dedupe-prompt-select-logic branch July 22, 2025 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants