Skip to content

Conversation

@timreichen
Copy link
Contributor

This PR replaces fmt to formatter because property abbreviations should be avoided as they are uncommon in web apis.

@timreichen timreichen requested a review from kt3k as a code owner June 2, 2025 23:17
@github-actions github-actions bot added the cli label Jun 2, 2025
@codecov
Copy link

codecov bot commented Jun 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.15%. Comparing base (eccdeff) to head (997251a).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6707      +/-   ##
==========================================
- Coverage   94.15%   94.15%   -0.01%     
==========================================
  Files         587      587              
  Lines       42468    42468              
  Branches     6702     6702              
==========================================
- Hits        39986    39985       -1     
- Misses       2433     2434       +1     
  Partials       49       49              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@kt3k kt3k added the feedback welcome We want community's feedback on this issue or PR label Jun 3, 2025
Copy link
Member

@kt3k kt3k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this aligned better with the rest of the code base. Thanks for your suggestion

LGTM

@kt3k kt3k changed the title BREAKING(cli/unstable): rename fmt to formatter BREAKING(cli/unstable): rename fmt of ProgressBarOption to formatter Jul 22, 2025
@kt3k kt3k merged commit cb16783 into denoland:main Jul 22, 2025
20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cli feedback welcome We want community's feedback on this issue or PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants