Aggregation bucket align (for RedisTimeSeries >= 1.6.0)#30
Aggregation bucket align (for RedisTimeSeries >= 1.6.0)#30dengliming merged 1 commit intodengliming:masterfrom
Conversation
67d7070 to
7d7b895
Compare
Codecov Report
@@ Coverage Diff @@
## master #30 +/- ##
============================================
+ Coverage 65.56% 65.68% +0.11%
- Complexity 580 585 +5
============================================
Files 104 105 +1
Lines 2053 2066 +13
Branches 172 173 +1
============================================
+ Hits 1346 1357 +11
- Misses 606 611 +5
+ Partials 101 98 -3
Continue to review full report at Codecov.
|
|
@xdev-developer Thanks for your contribution. Is this PR ready to merge? |
|
I'm trying add more understandable test. |
|
@dengliming should I ignore this test by default? (it will fail with redis ts < 1.6.0) |
7d7b895 to
9435174
Compare
|
@xdev-developer Looks good. Can you check the ci? There are some check style errors. : ) |
Agree. Let's ignore this test by default. We can test it with different versions in the future. e.g. we can introduce custom annotation for test. |
|
Yep, will fix soon |
9435174 to
54d197c
Compare
b3887f4 to
5eaba48
Compare
Signed-off-by: Den Kovalevskyi <xdev.developer@gmail.com>
5eaba48 to
9a1910d
Compare
|
@xdev-developer Thanks. That's merged. |
Aggregation align support.