Skip to content

TS.MRANGE IndexOutOfBoundsException problem fix #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dengliming merged 4 commits into from
Dec 6, 2021
Merged

TS.MRANGE IndexOutOfBoundsException problem fix #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
1f4f6c8
TS.MRANGE IndexOutOfBoundsException problem fix
xdev-developer Dec 3, 2021
bf9803e
Update redisai image
dengliming Dec 6, 2021
dafea5f
Fix check style
dengliming Dec 6, 2021
97925e7
Update redissearch image
dengliming Dec 6, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ jobs:
ports:
- 6379:6379
redisearch:
image: redislabs/redisearch:latest
image: redislabs/redisearch:2.0.9
options: >-
--health-cmd "redis-cli ping"
--health-interval 10s
Expand All @@ -41,7 +41,7 @@ jobs:
ports:
- 6381:6379
redisai:
image: redislabs/redisai:edge-cpu
image: redislabs/redisai:edge-cpu-bionic
options: >-
--health-cmd "redis-cli ping"
--health-interval 10s
Expand Down
7 changes: 5 additions & 2 deletions .../io/github/dengliming/redismodule/redistimeseries/protocol/decoder/TimeSeriesDecoder.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,11 +58,14 @@ public List<TimeSeries> decode(List<Object> parts, State state) {
List<Value> values = new ArrayList<>();
List<Object> objects = (List<Object>) o.get(2);
// all samples
if (objects.get(0) instanceof List) {
if (objects.size() > 0 && (objects.get(0) instanceof List)) {
((List<List<Object>>) o.get(2)).forEach(valueObject -> values.add(valueDecoder.decode(valueObject, state)));
} else {
// the last sample
values.add(valueDecoder.decode((List<Object>) o.get(2), state));
Value decoded = valueDecoder.decode(objects, state);
if (decoded != null) {
values.add(decoded);
}
}
series.values(values);
timeSeries.add(series);
Expand Down
6 changes: 6 additions & 0 deletions ...s/src/test/java/io/github/dengliming/redismodule/redistimeseries/RedisTimeSeriesTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,12 @@ public void testRange() {
assertThat(timeSeries).hasSize(1);
assertThat(timeSeries.get(0).getKey()).isEqualTo("temperature:2:33");

// Sensor exists, but no data in range
timeSeries = redisTimeSeries.mrange(0, 100, new RangeOptions()
.max(3).withLabels(), "sensor_id=2");
assertThat(timeSeries).hasSize(1);
assertThat(timeSeries.get(0).getValues()).isEmpty();

timeSeries = redisTimeSeries.mrange(timestamp, timestamp + 1, new RangeOptions()
.max(3).withLabels(), "sensor_id=1");
assertThat(timeSeries).isEmpty();
Expand Down