Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #18 +/- ##
============================================
- Coverage 61.04% 60.83% -0.22%
Complexity 462 462
============================================
Files 90 90
Lines 1743 1754 +11
Branches 152 157 +5
============================================
+ Hits 1064 1067 +3
- Misses 587 593 +6
- Partials 92 94 +2
Continue to review full report at Codecov.
|
dengliming
reviewed
Apr 18, 2021
...n/java/io/github/dengliming/redismodule/redisearch/protocol/decoder/SearchResultDecoder.java
Outdated
Show resolved
Hide resolved
Contributor
Author
|
Done! |
Owner
|
@regisoliveira Can you resolve conflicts? |
Contributor
Author
I don't have write access to your repo to solve conflicts. |
Owner
|
@regisoliveira Thanks. That's merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SearchResultDecodercrashes when usingio.github.dengliming.redismodule.redisearch.search.SearchOptions#withScoresequals totrue, since the response we get fromFT.SEARCHcontains the score value just after the document key.We will calculate the
documentsize usingpartsdata. After them, we use that size to iterate over thepartsand build aDocumentwith it's Key a Payload (previous behavior) or Key, Score and Payload (new behavior).It would be better if we could access the command's parameters inside the
SearchResultDecoderto assure what kind of response we are dealing with.Bellow there are 2 images that shows the parts differences without and with
withScoresparameter.