DLPX-84906 Disable frame buffer drivers by sumedhbala-delphix · Pull Request #26 · delphix/linux-kernel-gcp

sumedhbala-delphix · 2023-05-08T14:28:56Z

BugLink: https://bugs.launchpad.net/bugs/2032689 [ Upstream commit 8d21155 ] adjust_inuse_and_calc_cost() use spin_lock_irq() and IRQ will be enabled when unlock. DEADLOCK might happen if we have held other locks and disabled IRQ before invoking it. Fix it by using spin_lock_irqsave() instead, which can keep IRQ state consistent with before when unlock. ================================ WARNING: inconsistent lock state 5.10.0-02758-g8e5f91fd772f #26 Not tainted -------------------------------- inconsistent {IN-HARDIRQ-W} -> {HARDIRQ-ON-W} usage. kworker/2:3/388 [HC0[0]:SC0[0]:HE0:SE1] takes: ffff888118c00c28 (&bfqd->lock){?.-.}-{2:2}, at: spin_lock_irq ffff888118c00c28 (&bfqd->lock){?.-.}-{2:2}, at: bfq_bio_merge+0x141/0x390 {IN-HARDIRQ-W} state was registered at: __lock_acquire+0x3d7/0x1070 lock_acquire+0x197/0x4a0 __raw_spin_lock_irqsave _raw_spin_lock_irqsave+0x3b/0x60 bfq_idle_slice_timer_body bfq_idle_slice_timer+0x53/0x1d0 __run_hrtimer+0x477/0xa70 __hrtimer_run_queues+0x1c6/0x2d0 hrtimer_interrupt+0x302/0x9e0 local_apic_timer_interrupt __sysvec_apic_timer_interrupt+0xfd/0x420 run_sysvec_on_irqstack_cond sysvec_apic_timer_interrupt+0x46/0xa0 asm_sysvec_apic_timer_interrupt+0x12/0x20 irq event stamp: 837522 hardirqs last enabled at (837521): [<ffffffff84b9419d>] __raw_spin_unlock_irqrestore hardirqs last enabled at (837521): [<ffffffff84b9419d>] _raw_spin_unlock_irqrestore+0x3d/0x40 hardirqs last disabled at (837522): [<ffffffff84b93fa3>] __raw_spin_lock_irq hardirqs last disabled at (837522): [<ffffffff84b93fa3>] _raw_spin_lock_irq+0x43/0x50 softirqs last enabled at (835852): [<ffffffff84e00558>] __do_softirq+0x558/0x8ec softirqs last disabled at (835845): [<ffffffff84c010ff>] asm_call_irq_on_stack+0xf/0x20 other info that might help us debug this: Possible unsafe locking scenario: CPU0 ---- lock(&bfqd->lock); <Interrupt> lock(&bfqd->lock); *** DEADLOCK *** 3 locks held by kworker/2:3/388: #0: ffff888107af0f38 ((wq_completion)kthrotld){+.+.}-{0:0}, at: process_one_work+0x742/0x13f0 #1: ffff8881176bfdd8 ((work_completion)(&td->dispatch_work)){+.+.}-{0:0}, at: process_one_work+0x777/0x13f0 #2: ffff888118c00c28 (&bfqd->lock){?.-.}-{2:2}, at: spin_lock_irq #2: ffff888118c00c28 (&bfqd->lock){?.-.}-{2:2}, at: bfq_bio_merge+0x141/0x390 stack backtrace: CPU: 2 PID: 388 Comm: kworker/2:3 Not tainted 5.10.0-02758-g8e5f91fd772f #26 Hardware name: QEMU Standard PC (i440FX + PIIX, 1996), BIOS rel-1.14.0-0-g155821a1990b-prebuilt.qemu.org 04/01/2014 Workqueue: kthrotld blk_throtl_dispatch_work_fn Call Trace: __dump_stack lib/dump_stack.c:77 [inline] dump_stack+0x107/0x167 print_usage_bug valid_state mark_lock_irq.cold+0x32/0x3a mark_lock+0x693/0xbc0 mark_held_locks+0x9e/0xe0 __trace_hardirqs_on_caller lockdep_hardirqs_on_prepare.part.0+0x151/0x360 trace_hardirqs_on+0x5b/0x180 __raw_spin_unlock_irq _raw_spin_unlock_irq+0x24/0x40 spin_unlock_irq adjust_inuse_and_calc_cost+0x4fb/0x970 ioc_rqos_merge+0x277/0x740 __rq_qos_merge+0x62/0xb0 rq_qos_merge bio_attempt_back_merge+0x12c/0x4a0 blk_mq_sched_try_merge+0x1b6/0x4d0 bfq_bio_merge+0x24a/0x390 __blk_mq_sched_bio_merge+0xa6/0x460 blk_mq_sched_bio_merge blk_mq_submit_bio+0x2e7/0x1ee0 __submit_bio_noacct_mq+0x175/0x3b0 submit_bio_noacct+0x1fb/0x270 blk_throtl_dispatch_work_fn+0x1ef/0x2b0 process_one_work+0x83e/0x13f0 process_scheduled_works worker_thread+0x7e3/0xd80 kthread+0x353/0x470 ret_from_fork+0x1f/0x30 Fixes: b0853ab ("blk-iocost: revamp in-period donation snapbacks") Signed-off-by: Li Nan <linan122@huawei.com> Acked-by: Tejun Heo <tj@kernel.org> Reviewed-by: Yu Kuai <yukuai3@huawei.com> Link: https://lore.kernel.org/r/20230527091904.3001833-1-linan666@huaweicloud.com Signed-off-by: Jens Axboe <axboe@kernel.dk> Signed-off-by: Sasha Levin <sashal@kernel.org> Signed-off-by: Kamal Mostafa <kamal@canonical.com> Signed-off-by: Stefan Bader <stefan.bader@canonical.com>

PR URL: https://www.github.com/delphix/linux-kernel-gcp/pull/26

DLPX-84906 Disable frame buffer drivers

dc09f0f

PR URL: https://www.github.com/delphix/linux-kernel-gcp/pull/26

sumedhbala-delphix force-pushed the dlpx/pr/sumedhbala-delphix/fef6f020-3cf8-4188-b169-1b8498b8cd39 branch from a0772a6 to dc09f0f Compare May 8, 2023 14:29

prakashsurya approved these changes May 8, 2023

View reviewed changes

sumedhbala-delphix requested a review from sebroy May 9, 2023 01:22

sebroy approved these changes May 9, 2023

View reviewed changes

sumedhbala-delphix marked this pull request as ready for review May 9, 2023 14:28

sumedhbala-delphix merged commit f049c01 into develop May 9, 2023

sumedhbala-delphix deleted the dlpx/pr/sumedhbala-delphix/fef6f020-3cf8-4188-b169-1b8498b8cd39 branch May 9, 2023 14:28

prakashsurya pushed a commit that referenced this pull request May 18, 2023

DLPX-84906 Disable frame buffer drivers (#26)

d21ccdb

PR URL: https://www.github.com/delphix/linux-kernel-gcp/pull/26

delphix-devops-bot pushed a commit that referenced this pull request May 26, 2023

DLPX-84906 Disable frame buffer drivers (#26)

7bb910c

PR URL: https://www.github.com/delphix/linux-kernel-gcp/pull/26

delphix-devops-bot pushed a commit that referenced this pull request Jun 3, 2023

DLPX-84906 Disable frame buffer drivers (#26)

da81bd6

PR URL: https://www.github.com/delphix/linux-kernel-gcp/pull/26

delphix-devops-bot pushed a commit that referenced this pull request Jun 4, 2023

DLPX-84906 Disable frame buffer drivers (#26)

1a15872

PR URL: https://www.github.com/delphix/linux-kernel-gcp/pull/26

delphix-devops-bot pushed a commit that referenced this pull request Jun 5, 2023

DLPX-84906 Disable frame buffer drivers (#26)

623073f

PR URL: https://www.github.com/delphix/linux-kernel-gcp/pull/26

prakashsurya pushed a commit that referenced this pull request Aug 8, 2023

DLPX-84906 Disable frame buffer drivers (#26)

78c0e6d

PR URL: https://www.github.com/delphix/linux-kernel-gcp/pull/26

delphix-devops-bot pushed a commit that referenced this pull request Aug 24, 2023

DLPX-84906 Disable frame buffer drivers (#26)

de47afe

PR URL: https://www.github.com/delphix/linux-kernel-gcp/pull/26

delphix-devops-bot pushed a commit that referenced this pull request Aug 25, 2023

DLPX-84906 Disable frame buffer drivers (#26)

938768b

PR URL: https://www.github.com/delphix/linux-kernel-gcp/pull/26

delphix-devops-bot pushed a commit that referenced this pull request Aug 26, 2023

DLPX-84906 Disable frame buffer drivers (#26)

f260973

PR URL: https://www.github.com/delphix/linux-kernel-gcp/pull/26

delphix-devops-bot pushed a commit that referenced this pull request Aug 27, 2023

DLPX-84906 Disable frame buffer drivers (#26)

0ee769c

PR URL: https://www.github.com/delphix/linux-kernel-gcp/pull/26

delphix-devops-bot pushed a commit that referenced this pull request Sep 2, 2023

DLPX-84906 Disable frame buffer drivers (#26)

48fffbc

PR URL: https://www.github.com/delphix/linux-kernel-gcp/pull/26

delphix-devops-bot pushed a commit that referenced this pull request Sep 3, 2023

DLPX-84906 Disable frame buffer drivers (#26)

ec7039f

PR URL: https://www.github.com/delphix/linux-kernel-gcp/pull/26

delphix-devops-bot pushed a commit that referenced this pull request Sep 4, 2023

DLPX-84906 Disable frame buffer drivers (#26)

c501095

PR URL: https://www.github.com/delphix/linux-kernel-gcp/pull/26

delphix-devops-bot pushed a commit that referenced this pull request Sep 5, 2023

DLPX-84906 Disable frame buffer drivers (#26)

201a1dd

PR URL: https://www.github.com/delphix/linux-kernel-gcp/pull/26

delphix-devops-bot pushed a commit that referenced this pull request Sep 6, 2023

DLPX-84906 Disable frame buffer drivers (#26)

a92b21e

PR URL: https://www.github.com/delphix/linux-kernel-gcp/pull/26

delphix-devops-bot pushed a commit that referenced this pull request Sep 7, 2023

DLPX-84906 Disable frame buffer drivers (#26)

ce3051e

PR URL: https://www.github.com/delphix/linux-kernel-gcp/pull/26

delphix-devops-bot pushed a commit that referenced this pull request Sep 8, 2023

DLPX-84906 Disable frame buffer drivers (#26)

793e66d

PR URL: https://www.github.com/delphix/linux-kernel-gcp/pull/26

prakashsurya pushed a commit that referenced this pull request Sep 12, 2023

DLPX-84906 Disable frame buffer drivers (#26)

11baec1

PR URL: https://www.github.com/delphix/linux-kernel-gcp/pull/26

delphix-devops-bot pushed a commit that referenced this pull request Sep 20, 2023

DLPX-84906 Disable frame buffer drivers (#26)

5c23fde

PR URL: https://www.github.com/delphix/linux-kernel-gcp/pull/26

delphix-devops-bot pushed a commit that referenced this pull request Oct 6, 2023

DLPX-84906 Disable frame buffer drivers (#26)

0e05167

PR URL: https://www.github.com/delphix/linux-kernel-gcp/pull/26

delphix-devops-bot pushed a commit that referenced this pull request Oct 25, 2023

DLPX-84906 Disable frame buffer drivers (#26)

2675eb0

PR URL: https://www.github.com/delphix/linux-kernel-gcp/pull/26

pcd1193182 pushed a commit to pcd1193182/linux-kernel-gcp that referenced this pull request Feb 21, 2024

DLPX-84906 Disable frame buffer drivers (delphix#26)

a03806e

PR URL: https://www.github.com/delphix/linux-kernel-gcp/pull/26

delphix-devops-bot pushed a commit that referenced this pull request Mar 2, 2024

DLPX-84906 Disable frame buffer drivers (#26)

2d4232f

PR URL: https://www.github.com/delphix/linux-kernel-gcp/pull/26

delphix-devops-bot pushed a commit that referenced this pull request Mar 3, 2024

DLPX-84906 Disable frame buffer drivers (#26)

5063447

PR URL: https://www.github.com/delphix/linux-kernel-gcp/pull/26

delphix-devops-bot pushed a commit that referenced this pull request Mar 9, 2024

DLPX-84906 Disable frame buffer drivers (#26)

e88d4fb

PR URL: https://www.github.com/delphix/linux-kernel-gcp/pull/26

grwilson pushed a commit that referenced this pull request Mar 23, 2024

DLPX-84906 Disable frame buffer drivers (#26)

7efe1ac

PR URL: https://www.github.com/delphix/linux-kernel-gcp/pull/26

prakashsurya pushed a commit that referenced this pull request Mar 26, 2024

DLPX-84906 Disable frame buffer drivers (#26)

c46d893

PR URL: https://www.github.com/delphix/linux-kernel-gcp/pull/26

jwk404 pushed a commit that referenced this pull request Apr 14, 2024

DLPX-84906 Disable frame buffer drivers (#26)

9c8f36a

PR URL: https://www.github.com/delphix/linux-kernel-gcp/pull/26

jwk404 pushed a commit that referenced this pull request Apr 15, 2024

DLPX-84906 Disable frame buffer drivers (#26)

b5ec444

PR URL: https://www.github.com/delphix/linux-kernel-gcp/pull/26

jwk404 pushed a commit that referenced this pull request Apr 15, 2024

DLPX-84906 Disable frame buffer drivers (#26)

a4bae08

PR URL: https://www.github.com/delphix/linux-kernel-gcp/pull/26

jwk404 pushed a commit that referenced this pull request Apr 15, 2024

DLPX-84906 Disable frame buffer drivers (#26)

1c4e6db

PR URL: https://www.github.com/delphix/linux-kernel-gcp/pull/26

delphix-devops-bot pushed a commit that referenced this pull request Apr 20, 2024

DLPX-84906 Disable frame buffer drivers (#26)

7f251dd

PR URL: https://www.github.com/delphix/linux-kernel-gcp/pull/26

delphix-devops-bot pushed a commit that referenced this pull request May 9, 2024

DLPX-84906 Disable frame buffer drivers (#26)

c865ec4

PR URL: https://www.github.com/delphix/linux-kernel-gcp/pull/26

delphix-devops-bot pushed a commit that referenced this pull request May 16, 2024

DLPX-84906 Disable frame buffer drivers (#26)

c321c85

PR URL: https://www.github.com/delphix/linux-kernel-gcp/pull/26

delphix-devops-bot pushed a commit that referenced this pull request May 17, 2024

DLPX-84906 Disable frame buffer drivers (#26)

017c7e7

PR URL: https://www.github.com/delphix/linux-kernel-gcp/pull/26

delphix-devops-bot pushed a commit that referenced this pull request Jun 8, 2024

DLPX-84906 Disable frame buffer drivers (#26)

c36c74c

PR URL: https://www.github.com/delphix/linux-kernel-gcp/pull/26

delphix-devops-bot pushed a commit that referenced this pull request Jun 9, 2024

DLPX-84906 Disable frame buffer drivers (#26)

507a603

PR URL: https://www.github.com/delphix/linux-kernel-gcp/pull/26

delphix-devops-bot pushed a commit that referenced this pull request Aug 1, 2024

DLPX-84906 Disable frame buffer drivers (#26)

dddbe05

PR URL: https://www.github.com/delphix/linux-kernel-gcp/pull/26

delphix-devops-bot pushed a commit that referenced this pull request Aug 6, 2024

DLPX-84906 Disable frame buffer drivers (#26)

7fe8651

PR URL: https://www.github.com/delphix/linux-kernel-gcp/pull/26

delphix-devops-bot pushed a commit that referenced this pull request Aug 15, 2024

DLPX-84906 Disable frame buffer drivers (#26)

748953f

PR URL: https://www.github.com/delphix/linux-kernel-gcp/pull/26

delphix-devops-bot pushed a commit that referenced this pull request Aug 22, 2024

DLPX-84906 Disable frame buffer drivers (#26)

8b5da90

PR URL: https://www.github.com/delphix/linux-kernel-gcp/pull/26

delphix-devops-bot pushed a commit that referenced this pull request Aug 23, 2024

DLPX-84906 Disable frame buffer drivers (#26)

194a2c7

PR URL: https://www.github.com/delphix/linux-kernel-gcp/pull/26

prakashsurya pushed a commit that referenced this pull request Sep 23, 2024

DLPX-84906 Disable frame buffer drivers (#26)

0e11014

PR URL: https://www.github.com/delphix/linux-kernel-gcp/pull/26

delphix-devops-bot pushed a commit that referenced this pull request Oct 20, 2024

DLPX-84906 Disable frame buffer drivers (#26)

3a1cad1

PR URL: https://www.github.com/delphix/linux-kernel-gcp/pull/26

delphix-devops-bot pushed a commit that referenced this pull request Oct 21, 2024

DLPX-84906 Disable frame buffer drivers (#26)

afa7022

PR URL: https://www.github.com/delphix/linux-kernel-gcp/pull/26

palash-gandhi pushed a commit that referenced this pull request Oct 24, 2024

DLPX-84906 Disable frame buffer drivers (#26)

b01e297

PR URL: https://www.github.com/delphix/linux-kernel-gcp/pull/26

delphix-devops-bot pushed a commit that referenced this pull request Nov 10, 2024

DLPX-84906 Disable frame buffer drivers (#26)

35a972b

PR URL: https://www.github.com/delphix/linux-kernel-gcp/pull/26

delphix-devops-bot pushed a commit that referenced this pull request Nov 11, 2024

DLPX-84906 Disable frame buffer drivers (#26)

345d581

PR URL: https://www.github.com/delphix/linux-kernel-gcp/pull/26

delphix-devops-bot pushed a commit that referenced this pull request Dec 18, 2024

DLPX-84906 Disable frame buffer drivers (#26)

8241cc2

PR URL: https://www.github.com/delphix/linux-kernel-gcp/pull/26

delphix-devops-bot pushed a commit that referenced this pull request Dec 19, 2024

DLPX-84906 Disable frame buffer drivers (#26)

cf44cad

PR URL: https://www.github.com/delphix/linux-kernel-gcp/pull/26

delphix-devops-bot pushed a commit that referenced this pull request Dec 20, 2024

DLPX-84906 Disable frame buffer drivers (#26)

38d729b

PR URL: https://www.github.com/delphix/linux-kernel-gcp/pull/26

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

DLPX-84906 Disable frame buffer drivers#26

DLPX-84906 Disable frame buffer drivers#26
sumedhbala-delphix merged 1 commit into
developfrom
dlpx/pr/sumedhbala-delphix/fef6f020-3cf8-4188-b169-1b8498b8cd39

sumedhbala-delphix commented May 8, 2023

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

Conversation

sumedhbala-delphix commented May 8, 2023

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants