Skip to content

DLPX-83442 Disable various kernel modules which we don't use#14

Merged
prakashsurya merged 1 commit into
6.0/stagefrom
projects/ps-overrides
Nov 29, 2022
Merged

DLPX-83442 Disable various kernel modules which we don't use#14
prakashsurya merged 1 commit into
6.0/stagefrom
projects/ps-overrides

Conversation

@prakashsurya
Copy link
Copy Markdown

@prakashsurya prakashsurya commented Oct 19, 2022

No description provided.

@prakashsurya prakashsurya force-pushed the projects/ps-overrides branch from 4b079cc to 27ef64c Compare October 19, 2022 23:50
delphix-devops-bot pushed a commit that referenced this pull request Nov 4, 2022
@smb49
ipv6/addrconf: fix a null-ptr-deref bug for ip6_ptr
de1990b 
BugLink: https://bugs.launchpad.net/bugs/1989228

commit 85f0173 upstream.

Change net device's MTU to smaller than IPV6_MIN_MTU or unregister
device while matching route. That may trigger null-ptr-deref bug
for ip6_ptr probability as following.

=========================================================
BUG: KASAN: null-ptr-deref in find_match.part.0+0x70/0x134
Read of size 4 at addr 0000000000000308 by task ping6/263

CPU: 2 PID: 263 Comm: ping6 Not tainted 5.19.0-rc7+ #14
Call trace:
 dump_backtrace+0x1a8/0x230
 show_stack+0x20/0x70
 dump_stack_lvl+0x68/0x84
 print_report+0xc4/0x120
 kasan_report+0x84/0x120
 __asan_load4+0x94/0xd0
 find_match.part.0+0x70/0x134
 __find_rr_leaf+0x408/0x470
 fib6_table_lookup+0x264/0x540
 ip6_pol_route+0xf4/0x260
 ip6_pol_route_output+0x58/0x70
 fib6_rule_lookup+0x1a8/0x330
 ip6_route_output_flags_noref+0xd8/0x1a0
 ip6_route_output_flags+0x58/0x160
 ip6_dst_lookup_tail+0x5b4/0x85c
 ip6_dst_lookup_flow+0x98/0x120
 rawv6_sendmsg+0x49c/0xc70
 inet_sendmsg+0x68/0x94

Reproducer as following:
Firstly, prepare conditions:
$ip netns add ns1
$ip netns add ns2
$ip link add veth1 type veth peer name veth2
$ip link set veth1 netns ns1
$ip link set veth2 netns ns2
$ip netns exec ns1 ip -6 addr add 2001:0db8:0:f101::1/64 dev veth1
$ip netns exec ns2 ip -6 addr add 2001:0db8:0:f101::2/64 dev veth2
$ip netns exec ns1 ifconfig veth1 up
$ip netns exec ns2 ifconfig veth2 up
$ip netns exec ns1 ip -6 route add 2000::/64 dev veth1 metric 1
$ip netns exec ns2 ip -6 route add 2001::/64 dev veth2 metric 1

Secondly, execute the following two commands in two ssh windows
respectively:
$ip netns exec ns1 sh
$while true; do ip -6 addr add 2001:0db8:0:f101::1/64 dev veth1; ip -6 route add 2000::/64 dev veth1 metric 1; ping6 2000::2; done

$ip netns exec ns1 sh
$while true; do ip link set veth1 mtu 1000; ip link set veth1 mtu 1500; sleep 5; done

It is because ip6_ptr has been assigned to NULL in addrconf_ifdown() firstly,
then ip6_ignore_linkdown() accesses ip6_ptr directly without NULL check.

	cpu0			cpu1
fib6_table_lookup
__find_rr_leaf
			addrconf_notify [ NETDEV_CHANGEMTU ]
			addrconf_ifdown
			RCU_INIT_POINTER(dev->ip6_ptr, NULL)
find_match
ip6_ignore_linkdown

So we can add NULL check for ip6_ptr before using in ip6_ignore_linkdown() to
fix the null-ptr-deref bug.

Fixes: dcd1f57 ("net/ipv6: Remove fib6_idev")
Signed-off-by: Ziyang Xuan <william.xuanziyang@huawei.com>
Reviewed-by: David Ahern <dsahern@kernel.org>
Link: https://lore.kernel.org/r/20220728013307.656257-1-william.xuanziyang@huawei.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
sebroy
sebroy approved these changes Nov 28, 2022
View reviewed changes
Comment thread Makefile
@prakashsurya prakashsurya merged commit 177a020 into 6.0/stage Nov 29, 2022
@prakashsurya prakashsurya deleted the projects/ps-overrides branch November 29, 2022 02:35
don-brady pushed a commit to don-brady/linux-kernel-azure that referenced this pull request Nov 29, 2022
DLPX-83442 Disable various kernel modules which we don't use (delphix#14
6362c56 
)
delphix-devops-bot pushed a commit that referenced this pull request Dec 15, 2022
DLPX-83442 Disable various kernel modules which we don't use (#14)
7162f59
delphix-devops-bot pushed a commit that referenced this pull request Jan 11, 2023
DLPX-83442 Disable various kernel modules which we don't use (#14)
fa06987
delphix-devops-bot pushed a commit that referenced this pull request Feb 2, 2023
DLPX-83442 Disable various kernel modules which we don't use (#14)
56e8086
delphix-devops-bot pushed a commit that referenced this pull request Feb 10, 2023
DLPX-83442 Disable various kernel modules which we don't use (#14)
21362bc
delphix-devops-bot pushed a commit that referenced this pull request Mar 4, 2023
@smb49
arm64: Fix panic() when Spectre-v2 causes Spectre-BHB to re-allocate …
eee4b87 
…KVM vectors

BugLink: https://bugs.launchpad.net/bugs/2003896

Sami reports that linux panic()s when resuming from suspend to RAM. This
is because when CPUs are brought back online, they re-enable any
necessary mitigations.

The Spectre-v2 and Spectre-BHB mitigations interact as both need to
done by KVM when exiting a guest. Slots KVM can use as vectors are
allocated, and templates for the mitigation are patched into the vector.

This fails if a new slot needs to be allocated once the kernel has finished
booting as it is no-longer possible to modify KVM's vectors:
| root@adam:/sys/devices/system/cpu/cpu1# echo 1 > online
| Unable to handle kernel write to read-only memory at virtual add>
| Mem abort info:
|   ESR = 0x9600004e
|   Exception class = DABT (current EL), IL = 32 bits
|   SET = 0, FnV = 0
|   EA = 0, S1PTW = 0
| Data abort info:
|   ISV = 0, ISS = 0x0000004e
|   CM = 0, WnR = 1
| swapper pgtable: 4k pages, 48-bit VAs, pgdp = 000000000f07a71c
| [ffff800000b4b800] pgd=00000009ffff8803, pud=00000009ffff7803, p>
| Internal error: Oops: 9600004e [#1] PREEMPT SMP
| Modules linked in:
| Process swapper/1 (pid: 0, stack limit = 0x0000000063153c53)
| CPU: 1 PID: 0 Comm: swapper/1 Not tainted 4.19.252-dirty #14
| Hardware name: ARM LTD ARM Juno Development Platform/ARM Juno De>
| pstate: 000001c5 (nzcv dAIF -PAN -UAO)
| pc : __memcpy+0x48/0x180
| lr : __copy_hyp_vect_bpi+0x64/0x90

| Call trace:
|  __memcpy+0x48/0x180
|  kvm_setup_bhb_slot+0x204/0x2a8
|  spectre_bhb_enable_mitigation+0x1b8/0x1d0
|  __verify_local_cpu_caps+0x54/0xf0
|  check_local_cpu_capabilities+0xc4/0x184
|  secondary_start_kernel+0xb0/0x170
| Code: b8404423 b80044c3 3618006 f8408423 (f80084c3)
| ---[ end trace 859bcacb09555348 ]---
| Kernel panic - not syncing: Attempted to kill the idle task!
| SMP: stopping secondary CPUs
| Kernel Offset: disabled
| CPU features: 0x10,25806086
| Memory Limit: none
| ---[ end Kernel panic - not syncing: Attempted to kill the idle ]

This is only a problem on platforms where there is only one CPU that is
vulnerable to both Spectre-v2 and Spectre-BHB.

The Spectre-v2 mitigation identifies the slot it can re-use by the CPU's
'fn'. It unconditionally writes the slot number and 'template_start'
pointer. The Spectre-BHB mitigation identifies slots it can re-use by
the CPU's template_start pointer, which was previously clobbered by the
Spectre-v2 mitigation.

When there is only one CPU that is vulnerable to both issues, this causes
Spectre-v2 to try to allocate a new slot, which fails.

Change both mitigations to check whether they are changing the slot this
CPU uses before writing the percpu variables again.

This issue only exists in the stable backports for Spectre-BHB which have
to use totally different infrastructure to mainline.

Reported-by: Sami Lee <sami.lee@mediatek.com>
Fixes: 9013fd4bc958 ("arm64: Mitigate spectre style branch history side channels")
Signed-off-by: James Morse <james.morse@arm.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
delphix-devops-bot pushed a commit that referenced this pull request Mar 4, 2023
@liuhangbin @smb49
net/tunnel: wait until all sk_user_data reader finish before releasin…
104acb1 
…g the sock

BugLink: https://bugs.launchpad.net/bugs/2003914

[ Upstream commit 3cf7203 ]

There is a race condition in vxlan that when deleting a vxlan device
during receiving packets, there is a possibility that the sock is
released after getting vxlan_sock vs from sk_user_data. Then in
later vxlan_ecn_decapsulate(), vxlan_get_sk_family() we will got
NULL pointer dereference. e.g.

   #0 [ffffa25ec6978a38] machine_kexec at ffffffff8c669757
   #1 [ffffa25ec6978a90] __crash_kexec at ffffffff8c7c0a4d
   #2 [ffffa25ec6978b58] crash_kexec at ffffffff8c7c1c48
   #3 [ffffa25ec6978b60] oops_end at ffffffff8c627f2b
   #4 [ffffa25ec6978b80] page_fault_oops at ffffffff8c678fcb
   #5 [ffffa25ec6978bd8] exc_page_fault at ffffffff8d109542
   #6 [ffffa25ec6978c00] asm_exc_page_fault at ffffffff8d200b62
      [exception RIP: vxlan_ecn_decapsulate+0x3b]
      RIP: ffffffffc1014e7b  RSP: ffffa25ec6978cb0  RFLAGS: 00010246
      RAX: 0000000000000008  RBX: ffff8aa000888000  RCX: 0000000000000000
      RDX: 000000000000000e  RSI: ffff8a9fc7ab803e  RDI: ffff8a9fd1168700
      RBP: ffff8a9fc7ab803e   R8: 0000000000700000   R9: 00000000000010ae
      R10: ffff8a9fcb748980  R11: 0000000000000000  R12: ffff8a9fd1168700
      R13: ffff8aa000888000  R14: 00000000002a0000  R15: 00000000000010ae
      ORIG_RAX: ffffffffffffffff  CS: 0010  SS: 0018
   #7 [ffffa25ec6978ce8] vxlan_rcv at ffffffffc10189cd [vxlan]
   #8 [ffffa25ec6978d90] udp_queue_rcv_one_skb at ffffffff8cfb6507
   #9 [ffffa25ec6978dc0] udp_unicast_rcv_skb at ffffffff8cfb6e45
  #10 [ffffa25ec6978dc8] __udp4_lib_rcv at ffffffff8cfb8807
  #11 [ffffa25ec6978e20] ip_protocol_deliver_rcu at ffffffff8cf76951
  #12 [ffffa25ec6978e48] ip_local_deliver at ffffffff8cf76bde
  #13 [ffffa25ec6978ea0] __netif_receive_skb_one_core at ffffffff8cecde9b
  #14 [ffffa25ec6978ec8] process_backlog at ffffffff8cece139
  #15 [ffffa25ec6978f00] __napi_poll at ffffffff8ceced1a
  #16 [ffffa25ec6978f28] net_rx_action at ffffffff8cecf1f3
  #17 [ffffa25ec6978fa0] __softirqentry_text_start at ffffffff8d4000ca
  #18 [ffffa25ec6978ff0] do_softirq at ffffffff8c6fbdc3

Reproducer: https://github.com/Mellanox/ovs-tests/blob/master/test-ovs-vxlan-remove-tunnel-during-traffic.sh

Fix this by waiting for all sk_user_data reader to finish before
releasing the sock.

Reported-by: Jianlin Shi <jishi@redhat.com>
Suggested-by: Jakub Sitnicki <jakub@cloudflare.com>
Fixes: 6a93cc9 ("udp-tunnel: Add a few more UDP tunnel APIs")
Signed-off-by: Hangbin Liu <liuhangbin@gmail.com>
Reviewed-by: Jiri Pirko <jiri@nvidia.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>
Signed-off-by: Kamal Mostafa <kamal@canonical.com>
Signed-off-by: Stefan Bader <stefan.bader@canonical.com>
delphix-devops-bot pushed a commit that referenced this pull request Mar 4, 2023
DLPX-83442 Disable various kernel modules which we don't use (#14)
fbbab13
prakashsurya pushed a commit that referenced this pull request Mar 14, 2023
DLPX-83442 Disable various kernel modules which we don't use (#14)
7b7f2c9
prakashsurya pushed a commit that referenced this pull request Mar 14, 2023
DLPX-83442 Disable various kernel modules which we don't use (#14)
cf39d80
delphix-devops-bot pushed a commit that referenced this pull request Mar 30, 2023
DLPX-83442 Disable various kernel modules which we don't use (#14)
e40a828
delphix-devops-bot pushed a commit that referenced this pull request Apr 20, 2023
DLPX-83442 Disable various kernel modules which we don't use (#14)
b786e4f
delphix-devops-bot pushed a commit that referenced this pull request Apr 28, 2023
DLPX-83442 Disable various kernel modules which we don't use (#14)
8db461b
This was referenced May 23, 2023
Merged
Merged
Merged
Merged
delphix-devops-bot pushed a commit that referenced this pull request May 26, 2023
DLPX-83442 Disable various kernel modules which we don't use (#14)
5e2a2bf
delphix-devops-bot pushed a commit that referenced this pull request Dec 9, 2023
DLPX-83442 Disable various kernel modules which we don't use (#14)
fb526ef
delphix-devops-bot pushed a commit that referenced this pull request Jan 27, 2024
DLPX-83442 Disable various kernel modules which we don't use (#14)
8925d0a
delphix-devops-bot pushed a commit that referenced this pull request Feb 17, 2024
DLPX-83442 Disable various kernel modules which we don't use (#14)
dbdb3c5
delphix-devops-bot pushed a commit that referenced this pull request Feb 18, 2024
DLPX-83442 Disable various kernel modules which we don't use (#14)
1d434c1
delphix-devops-bot pushed a commit that referenced this pull request Feb 19, 2024
DLPX-83442 Disable various kernel modules which we don't use (#14)
a425eb1
delphix-devops-bot pushed a commit that referenced this pull request Feb 20, 2024
DLPX-83442 Disable various kernel modules which we don't use (#14)
7db17a3
delphix-devops-bot pushed a commit that referenced this pull request Feb 21, 2024
DLPX-83442 Disable various kernel modules which we don't use (#14)
f4ab554
delphix-devops-bot pushed a commit that referenced this pull request Feb 22, 2024
DLPX-83442 Disable various kernel modules which we don't use (#14)
6870e23
delphix-devops-bot pushed a commit that referenced this pull request Feb 23, 2024
DLPX-83442 Disable various kernel modules which we don't use (#14)
fef6a6a
delphix-devops-bot pushed a commit that referenced this pull request Feb 24, 2024
DLPX-83442 Disable various kernel modules which we don't use (#14)
8fd3ab9
delphix-devops-bot pushed a commit that referenced this pull request Feb 25, 2024
DLPX-83442 Disable various kernel modules which we don't use (#14)
b0eb6be
delphix-devops-bot pushed a commit that referenced this pull request Feb 26, 2024
DLPX-83442 Disable various kernel modules which we don't use (#14)
b387090
delphix-devops-bot pushed a commit that referenced this pull request Feb 27, 2024
DLPX-83442 Disable various kernel modules which we don't use (#14)
6d239db
delphix-devops-bot pushed a commit that referenced this pull request Feb 28, 2024
DLPX-83442 Disable various kernel modules which we don't use (#14)
118fe33
delphix-devops-bot pushed a commit that referenced this pull request Feb 29, 2024
DLPX-83442 Disable various kernel modules which we don't use (#14)
d9050c7
delphix-devops-bot pushed a commit that referenced this pull request Mar 1, 2024
DLPX-83442 Disable various kernel modules which we don't use (#14)
add71ae
delphix-devops-bot pushed a commit that referenced this pull request Mar 2, 2024
DLPX-83442 Disable various kernel modules which we don't use (#14)
f76c381
delphix-devops-bot pushed a commit that referenced this pull request Mar 3, 2024
DLPX-83442 Disable various kernel modules which we don't use (#14)
9093797
delphix-devops-bot pushed a commit that referenced this pull request Mar 4, 2024
DLPX-83442 Disable various kernel modules which we don't use (#14)
048710a
delphix-devops-bot pushed a commit that referenced this pull request Mar 5, 2024
DLPX-83442 Disable various kernel modules which we don't use (#14)
4e27eed
delphix-devops-bot pushed a commit that referenced this pull request Mar 6, 2024
DLPX-83442 Disable various kernel modules which we don't use (#14)
4c4a2a6
delphix-devops-bot pushed a commit that referenced this pull request Mar 7, 2024
DLPX-83442 Disable various kernel modules which we don't use (#14)
b40f26c
delphix-devops-bot pushed a commit that referenced this pull request Mar 8, 2024
DLPX-83442 Disable various kernel modules which we don't use (#14)
1ddf57e
delphix-devops-bot pushed a commit that referenced this pull request Mar 9, 2024
DLPX-83442 Disable various kernel modules which we don't use (#14)
f2df9d8
delphix-devops-bot pushed a commit that referenced this pull request Mar 10, 2024
DLPX-83442 Disable various kernel modules which we don't use (#14)
b671fda
delphix-devops-bot pushed a commit that referenced this pull request Mar 11, 2024
DLPX-83442 Disable various kernel modules which we don't use (#14)
4e826da
delphix-devops-bot pushed a commit that referenced this pull request Mar 12, 2024
DLPX-83442 Disable various kernel modules which we don't use (#14)
c1af1f9
delphix-devops-bot pushed a commit that referenced this pull request Mar 13, 2024
DLPX-83442 Disable various kernel modules which we don't use (#14)
5daf574
delphix-devops-bot pushed a commit that referenced this pull request Mar 14, 2024
DLPX-83442 Disable various kernel modules which we don't use (#14)
fc1cac7
delphix-devops-bot pushed a commit that referenced this pull request Mar 15, 2024
DLPX-83442 Disable various kernel modules which we don't use (#14)
d2ee945
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sebroy sebroy sebroy approved these changes

+1 more reviewer

@sdimitro sdimitro sdimitro approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@prakashsurya @sebroy @sdimitro