Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion deepspeed/inference/config.py
Original file line number Diff line number Diff line change
Expand Up @@ -313,7 +313,7 @@ def validate_dtype(cls, field_value, values):
@field_validator("moe")
def moe_backward_compat(cls, field_value, values):
if isinstance(field_value, bool):
return DeepSpeedMoEConfig(moe=field_value)
return DeepSpeedMoEConfig(enabled=field_value)
return field_value

@field_validator("use_triton")
Expand Down
10 changes: 10 additions & 0 deletions tests/unit/inference/test_inference_config.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,3 +42,13 @@ def test_json_config(self, tmpdir):

engine = deepspeed.init_inference(torch.nn.Module(), config=config_json)
assert engine._config.replace_with_kernel_inject

def test_moe_backward_compat_bool(self):
# `moe` accepts a bool for backward compatibility (moe: Union[bool, DeepSpeedMoEConfig]);
# it should build a DeepSpeedMoEConfig rather than raising a validation error.
from deepspeed.inference.config import DeepSpeedInferenceConfig, DeepSpeedMoEConfig

for value in (True, False):
config = DeepSpeedInferenceConfig(moe=value)
assert isinstance(config.moe, DeepSpeedMoEConfig)
assert config.moe.enabled == value
Loading