Skip to content

Fix torch include in op_builder/mlu/fused_adam.py and update no-torch workflow triggers #6584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
loadams merged 5 commits into from
Sep 27, 2024
Merged

Fix torch include in op_builder/mlu/fused_adam.py and update no-torch workflow triggers #6584

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1891fed
Fix MLU op builder torch install
loadams Sep 27, 2024
f57b2ae
Update triggers for no-torch test
loadams Sep 27, 2024
5ea5ab0
Formatting/syntax error
loadams Sep 27, 2024
54ce016
Fix syntax
loadams Sep 27, 2024
a257e50
Merge branch 'loadams/fix-no-torch-failure-mlu' into loadams/fix-trig…
loadams Sep 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/no-torch.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ on:
pull_request:
paths:
- '.github/workflows/no-torch.yml'
- 'op_builder/**'
schedule:
- cron: "0 0 * * *"

Expand Down
6 changes: 5 additions & 1 deletion op_builder/mlu/fused_adam.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,11 @@
# DeepSpeed Team

from .builder import MLUOpBuilder
import torch

@loadams loadams Sep 27, 2024

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @Andy666G - this change broke the no-torch workflow. See more info in the PR comment, but please let us know if you have any concerns with this change,


try:

@tohtana tohtana Sep 27, 2024

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we import torch in multi_tensor_adam if it is the only place where you need torch?
Then you can throw a more specific error when torch is unavailable and multi_tensor_adam is called.

import torch
except ImportError as e:
pass


class MLUFusedAdam:
Expand Down