Skip to content

Fix CPUAdam for when vendor_id_raw is not provided #2836

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tjruwase merged 9 commits into from
Feb 28, 2023
Merged

Fix CPUAdam for when vendor_id_raw is not provided #2836

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7408f8c
#1213: Fix CPUAdam for when `vendor_id_raw` is not provided
FarzanT Feb 15, 2023
fe5c06c
Merge branch 'master' into CPUAdam_on_PowerPC
tjruwase Feb 15, 2023
1b2c3d4
formatting (yapf) fix
FarzanT Feb 15, 2023
2682448
Merge branch 'master' into CPUAdam_on_PowerPC
tjruwase Feb 15, 2023
519236d
Merge branch 'master' into CPUAdam_on_PowerPC
tjruwase Feb 15, 2023
a158e0c
Merge branch 'master' into CPUAdam_on_PowerPC
tjruwase Feb 24, 2023
697b59f
Merge branch 'master' into CPUAdam_on_PowerPC
tjruwase Feb 25, 2023
dad8edb
Merge branch 'master' into CPUAdam_on_PowerPC
tjruwase Feb 28, 2023
d42b8e8
Merge branch 'master' into CPUAdam_on_PowerPC
tjruwase Feb 28, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion deepspeed/ops/adam/cpu_adam.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,7 +75,9 @@ def __init__(self,
amsgrad=amsgrad)
super(DeepSpeedCPUAdam, self).__init__(model_params, default_args)

self.cpu_vendor = get_cpu_info()["vendor_id_raw"].lower()
cpu_info = get_cpu_info()
self.cpu_vendor = cpu_info["vendor_id_raw"].lower(
) if "vendor_id_raw" in cpu_info else "unknown"
if "amd" in self.cpu_vendor:
for group_id, group in enumerate(self.param_groups):
for param_id, p in enumerate(group['params']):
Expand Down