Skip to content

Dont overwrite hook handles in flop profiler #2106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tjruwase merged 4 commits into from
Jul 19, 2022
Merged

Dont overwrite hook handles in flop profiler #2106

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8db692a
Dont overwrite hook handles in flop profiler
Sanger2000 Jul 18, 2022
23a6042
Merge branch 'master' into flops-profile-fix
tjruwase Jul 18, 2022
c940655
Merge branch 'master' into flops-profile-fix
Sanger2000 Jul 19, 2022
8b16390
Merge branch 'master' into flops-profile-fix
tjruwase Jul 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 13 additions & 7 deletions deepspeed/profiling/flops_profiler/profiler.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,16 +74,18 @@ def register_module_hooks(module, ignore_list):

# if computing the flops of a module directly
if type(module) in MODULE_HOOK_MAPPING:
module.__flops_handle__ = module.register_forward_hook(
MODULE_HOOK_MAPPING[type(module)])
if not hasattr(module, "__flops_handle__"):
module.__flops_handle__ = module.register_forward_hook(
MODULE_HOOK_MAPPING[type(module)])
return

# if computing the flops of the functionals in a module
def pre_hook(module, input):
module_flop_count.append([])
module_mac_count.append([])

module.__pre_hook_handle__ = module.register_forward_pre_hook(pre_hook)
if not hasattr(module, "__pre_hook_handle__"):
module.__pre_hook_handle__ = module.register_forward_pre_hook(pre_hook)

def post_hook(module, input, output):
if module_flop_count:
Expand All @@ -92,20 +94,24 @@ def post_hook(module, input, output):
module.__macs__ += sum([elem[1] for elem in module_mac_count[-1]])
module_mac_count.pop()

module.__post_hook_handle__ = module.register_forward_hook(post_hook)
if not hasattr(module, "__post_hook_handle__"):
module.__post_hook_handle__ = module.register_forward_hook(post_hook)

def start_time_hook(module, input):
torch.cuda.synchronize()
module.__start_time__ = time.time()

module.__start_time_hook_handle__ = module.register_forward_pre_hook(
start_time_hook)
if not hasattr(module, "__start_time_hook_handle"):
module.__start_time_hook_handle__ = module.register_forward_pre_hook(
start_time_hook)

def end_time_hook(module, input, output):
torch.cuda.synchronize()
module.__duration__ += time.time() - module.__start_time__

module.__end_time_hook_handle__ = module.register_forward_hook(end_time_hook)
if not hasattr(module, "__end_time_hook_handle__"):
module.__end_time_hook_handle__ = module.register_forward_hook(
end_time_hook)

self.model.apply(partial(register_module_hooks, ignore_list=ignore_list))
self.started = True
Expand Down