Skip to content

fix(valkey): add client_name to Valkey connection configuration#3418

Merged
bogdankostic merged 1 commit into
deepset-ai:mainfrom
SyedShahmeerAli12:fix/valkey-client-name-clean
Jun 10, 2026
Merged

fix(valkey): add client_name to Valkey connection configuration#3418
bogdankostic merged 1 commit into
deepset-ai:mainfrom
SyedShahmeerAli12:fix/valkey-client-name-clean

Conversation

@SyedShahmeerAli12

Copy link
Copy Markdown
Contributor

Related Issues

Closes #3356

Proposed Changes

Add client_name=haystack_vector_store_client to SyncGlideClientConfiguration and GlideClientConfiguration when creating standalone (non-cluster) Valkey connections.

This makes Haystack connections identifiable in monitoring tools like CLIENT LIST, Valkey Admin, and CloudWatch metrics (ElastiCache).

How did you test it

The change adds a known parameter to an existing configuration object. No logic is affected.

Notes for the reviewer

Applied to both sync and async paths for consistency.

Checklist

  • I have read the contributors guidelines
  • I have updated the related component(s) documentation if needed
  • I have added tests for the changes I made (if applicable)
  • I have updated the CHANGELOG.md file in the relevant integration folder

@SyedShahmeerAli12 SyedShahmeerAli12 requested a review from a team as a code owner June 8, 2026 14:29
@SyedShahmeerAli12 SyedShahmeerAli12 requested review from bogdankostic and removed request for a team June 8, 2026 14:29
@github-actions

github-actions Bot commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Coverage report (valkey)

Click to see where and how coverage changed

FileStatementsMissingCoverageCoverage
(new stmts)
Lines missing
  integrations/valkey/src/haystack_integrations/document_stores/valkey
  document_store.py 241, 278-279
Project Total  

This report was generated by python-coverage-comment-action

@bogdankostic bogdankostic left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @SyedShahmeerAli12! :)

@bogdankostic bogdankostic merged commit 679704f into deepset-ai:main Jun 10, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add CLIENT SETNAME to Valkey document store for connection identification

2 participants