Conversation
|
No actionable comments were generated in the recent review. 🎉 📝 WalkthroughWalkthroughA walkthrough manifest for Deepnote onboarding has been added to the extension. The 🚥 Pre-merge checks | ✅ 5 | ❌ 1❌ Failed checks (1 inconclusive)
✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #321 +/- ##
===========================
===========================
🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@package.nls.json`:
- Around line 298-317: This JSON file failed Prettier formatting; run Prettier
(or your repo's formatter) on package.nls.json and commit the reformatted file
so keys like
"contributes.walkthroughs.deepnoteWelcome.steps.exploreProjects.description" and
other "contributes.walkthroughs.deepnoteWelcome.*" entries are properly
formatted/escaped according to the project's Prettier config; ensure no trailing
commas, correct indentation, and valid JSON syntax before committing.
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Inline comments:
In `@package.nls.json`:
- Around line 301-305: The walkthrough references a non-existent command
deepnoteExplorer.focus in the package.nls.json key
contributes.walkthroughs.deepnoteWelcome.steps.exploreProjects.description;
update this to a registered command or register the command: either change the
command token to an existing exported/declared command such as
deepnote.refreshExplorer or deepnote.revealInExplorer (ensuring the token
matches an entry in package.json "contributes.commands" and the command
implementation name), or add a new command named deepnoteExplorer.focus to
package.json and implement/exports that command in the extension activation code
so the walkthrough link resolves.
dinohamzic
left a comment
There was a problem hiding this comment.
Nice improvement, left some suggestions.
package.nls.json
Outdated
| "contributes.walkthroughs.deepnoteWelcome.description": "Your first steps to set up and explore Deepnote notebooks in VS Code.", | ||
| "contributes.walkthroughs.deepnoteWelcome.steps.exploreProjects.title": "Explore Your Projects", | ||
| "contributes.walkthroughs.deepnoteWelcome.steps.exploreProjects.description": { | ||
| "message": "Open the Deepnote sidebar to browse your projects and notebooks. Create new projects, import existing notebooks, and organize your work.\n[Open Deepnote Explorer](command:deepnoteExplorer.focus)", |
There was a problem hiding this comment.
This can be simplified to:
Use the Deepnote sidebar to browse, create, import, and organize your projects and notebooks.
package.nls.json
Outdated
| "comment": ["{Locked='command:deepnoteExplorer.focus'}"] | ||
| }, | ||
| "contributes.walkthroughs.deepnoteWelcome.steps.exploreProjects.media.altText": "The Deepnote Explorer sidebar showing projects and notebooks", | ||
| "contributes.walkthroughs.deepnoteWelcome.steps.notebookBlocks.title": "Work with Notebook Blocks", |
There was a problem hiding this comment.
Should we be more explicit here? It's unclear what "work" really means here.
eg. "Create your first notebook block"
| "contributes.walkthroughs.deepnoteWelcome.steps.connectDataSources.title": "Connect to Your Data Sources", | ||
| "contributes.walkthroughs.deepnoteWelcome.steps.connectDataSources.description": "Set up integrations to connect your notebooks to databases, data warehouses, and other services. Query your data directly from SQL blocks.", | ||
| "contributes.walkthroughs.deepnoteWelcome.steps.connectDataSources.media.altText": "The Manage Integrations panel for connecting data sources", | ||
| "contributes.walkthroughs.deepnoteWelcome.steps.setupEnvironment.title": "Set Up a Python Environment", |
There was a problem hiding this comment.
Should setting up a python environment be the first thing the user does?
There was a problem hiding this comment.
Maybe, but I think it's less important for showing the value of the extension.
Fixes #317
Summary by CodeRabbit
New Features
Documentation