chore(deps): Update dependencies in bulk (filelock, pynacl, urllib3)#52
chore(deps): Update dependencies in bulk (filelock, pynacl, urllib3)#52
Conversation
📝 WalkthroughWalkthroughThe pull request updates dependency constraints in 🚥 Pre-merge checks | ✅ 3✅ Passed checks (3 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. Comment |
|
📦 Python package built successfully!
|
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Fix all issues with AI agents
In `@pyproject.toml`:
- Around line 208-209: The dev dependency for virtualenv currently lacks an
upper-bound and should follow the project's "<X.0.0" pattern for consistency;
update the string "virtualenv>=20.36.1" to include an upper bound like
"virtualenv>=20.36.1,<21.0.0" in pyproject.toml so it matches the existing style
used for other dev deps.
- Around line 139-147: The pyproject dependency list is missing a urllib3
constraint for Python 3.9 (Snowflake requires urllib3 <2.0.0); add a urllib3
dependency entry that restricts urllib3 to be below 2.0.0 specifically for
python_version == '3.9' (mirroring the style of the existing urllib3 entry for
python_version >= '3.10') so that urllib3 is constrained to <2.0.0 on 3.9 while
leaving the >= '3.10' entry intact.
📜 Review details
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Disabled knowledge base sources:
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
⛔ Files ignored due to path filters (1)
poetry.lockis excluded by!**/*.lock
📒 Files selected for processing (1)
pyproject.toml
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (15)
- GitHub Check: Test - Python 3.12
- GitHub Check: Test - Python 3.10
- GitHub Check: Test - Python 3.11
- GitHub Check: Test - Python 3.9
- GitHub Check: Typecheck - 3.9
- GitHub Check: Test - Python 3.13
- GitHub Check: Typecheck - 3.13
- GitHub Check: Typecheck - 3.12
- GitHub Check: Typecheck - 3.11
- GitHub Check: Typecheck - 3.10
- GitHub Check: Build and push artifacts for Python 3.10
- GitHub Check: Build and push artifacts for Python 3.11
- GitHub Check: Build and push artifacts for Python 3.13
- GitHub Check: Build and push artifacts for Python 3.12
- GitHub Check: Build and push artifacts for Python 3.9
🔇 Additional comments (1)
pyproject.toml (1)
99-99: LGTM. Minor version bump for snowflake-sqlalchemy.
✏️ Tip: You can disable this entire section by setting review_details to false in your review settings.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #52 +/- ##
=======================================
Coverage 73.27% 73.27%
=======================================
Files 93 93
Lines 5194 5194
Branches 758 758
=======================================
Hits 3806 3806
Misses 1144 1144
Partials 244 244
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
🚀 Review App Deployment Started
|
Summary by CodeRabbit
✏️ Tip: You can customize this high-level summary in your review settings.